[HOLD for payment 2023-12-20] [$500] IOU - User is redirected to participant selection page after adding a receipt

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.11-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Tap + > Request money > Manual.
3. Enter amount and select a participant.
4. On the confirmation page, tap 3-dot menu > Add receipt.
5. Add a receipt from gallery (not able to reproduce issue if photo is taken from camera).

Expected Result:

After adding a receipt, user will be redirected to confirmation page.

Actual Result:

After adding a receipt, user is redirected to participant selection page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309297_1702313339652.Screen_Recording_20231212_000106_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016bea7c150b473a99
• Upwork Job ID: 1734285072060637184
• Last Price Increase: 2023-12-11
• Automatic offers:
• c3024 | Reviewer | 28037343
• abzokhattab | Contributor | 28037345

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

USer is redirected to particpants page after adding a receipt

What is the root cause of that problem?

in case of mobile we redirect the user to selection page :

App/src/pages/iou/request/step/IOURequestStepScan/index.native.js

Line 245 in 4c61f05

Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_PARTICIPANTS.getRoute(iouType, transactionID, reportID));

What changes do you think we should make in order to solve the problem?

redirect the user to the confirmation page

ROUTES.MONEY_REQUEST_CONFIRMATION.getRoute(iouType, transactionID, reportID)

also we need to update this:

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 221 in a630084

_.some(participants, (participant) => lodashGet(participant, 'searchText', '').toLowerCase().includes(searchTerm.trim().toLowerCase())),

to use lodashGet because it thows an error when adding a recept in IOS:

        _.some(participants, (participant) => lodashGet(participant, 'searchText', '').toLowerCase().includes(searchTerm.trim().toLowerCase())),

[marcochavezf]

Thanks @abzokhattab, the proposed solution looks good, assigning you 🚀

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016bea7c150b473a99

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[joekaufmanexpensify]

@abzokhattab let us know once a PR is up!

[abzokhattab]

The PR is there

[c3024]

When this bug was found index.js of IOURequestStepScan was wrapped with withWritableReportOrNotFound but index.native.js was not.

[This] (#32810) added the HOC to index.native.js as well and the bug does not appear now.

We have navigation to participants in index.js here

App/src/pages/iou/request/step/IOURequestStepScan/index.js

Line 144 in 4239252

Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_PARTICIPANTS.getRoute(iouType, transactionID, reportID));

and here

App/src/pages/iou/request/step/IOURequestStepScan/index.js

Line 173 in 4239252

Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_PARTICIPANTS.getRoute(iouType, transactionID, reportID));

as well but they are not reached because there is a reportID existing when we add image.

After wrapping the index.native.js as well with the HOC, it will not reach to the line navigating to the participants.

I think, if we change these participant page navigation lines to confirm page navigation lines, it will bring inconsistency between index.js and index.native.js.

I think we should change only the lodash change in the PR and not the navigation lines.

If we like to change these as well I think we should make the change in index.js as well.

@luacmartins @marcochavezf

[abzokhattab]

I agree that by adding the writableReport HOC, we will always have a reportID, thus we can just only change the lodassh change ... let me know if we should revert the navigation changes or keep them

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Stag] Fix redirection to confirmation page when adding a receipt #32892

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @abzokhattab requires payment automatic offer (Contributor)
• @c3024 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR: No specific PR caused this. Similar logic is used in different components however in this case value was undefined causing the bug.
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A. this is an edge case
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[joekaufmanexpensify]

@c3024 could you please handle the BZ checklist so we can prep to issue payment on Wednesday? TY!

[joekaufmanexpensify]

Bumped in Slack

[c3024]

• [@c3024] The PR that introduced the bug has been identified. Link to the PR: No specific PR caused this. Similar logic is used in different components however in this case value was undefined causing the bug.
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A. this is an edge case
• [@c3024] Determine if we should create a regression test for this bug: Not necessary as this is a minor change and does not affect anything else.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[joekaufmanexpensify]

BZ checklist complete. All set to issue payment tomorrow, which is:

• @abzokhattab - $500 for PR, paid via Upwork.
• @c3024 - $500 for C+, paid via Upwork.

[joekaufmanexpensify]

All set to issue payment.

[joekaufmanexpensify]

@abzokhattab $500 sent and contract ended!

[joekaufmanexpensify]

@c3024 $500 sent and contract ended!

[joekaufmanexpensify]

Upwork job removed.

[joekaufmanexpensify]

All set. Thanks everyone!