[HOLD for payment 2024-01-24] [$500] Android - Request-Wrong error message appears when tryin to choose my location for start and finish

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.11-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open the App
2. Login with any account
3. Go to FAB -> Request money -> Distance
4. Choose my location for start and finish points

Expected Result:

There should not be an error message, only when you later create a request, an error appears that you need to select different addresses

Actual Result:

An error message appears if choose as Finish point my location if `my location was chosen as Start point before

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309598_1702326077221.Record_2023-12-11-18-29-57_4f9154176b47c00da84e32064abf1c48.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019bd90e7731b4b6c6
• Upwork Job ID: 1737972831436316672
• Last Price Increase: 2023-12-28

Issue Owner

Current Issue Owner: @sakluger

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[yuwenmemon]

Taking a look

[yuwenmemon]

Figuring out Android on dev... https://expensify.slack.com/archives/C01GTK53T8Q/p1702338402694549

[yuwenmemon]

It seems like this is by design and would happen on production too:

App/src/libs/getCurrentPosition/index.android.ts

Lines 38 to 43 in ae8ec7a

	// An error here can be because of these reasons
	// 1. User denied location permission
	// 2. Failure to open the permission dialog
	// 3. Device location settings can't be changed or the device doesn't support some location settings
	// 4. Any internal error
	// For all of these we will return a permission denied error.

For all errors, we show a "Permission Denied" error. cc @huzaifa-99

[yuwenmemon]

I also can't seem to reproduce locally:

Kapture.2023-12-11.at.17.41.15.mp4

So going to remove the blocker and unassign.

@huzaifa-99 curious for your thoughts here

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[huzaifa-99]

Hi @yuwenmemon.

It seems like this is by design and would happen on production too.
// An error here can be because of these reasons
// 1. User denied location permission
// 2. Failure to open the permission dialog
// 3. Device location settings can't be changed or the device doesn't support some location settings
// 4. Any internal error
// For all of these we will return a permission denied error.
For all errors, we show a "Permission Denied" error. cc @huzaifa-99

Yes, we have to allow location permission.

@huzaifa-99 curious for your thoughts here

If location permission is allowed then it's up to the mobile phone's GPS to give us the location, if it fails to do so then we will get the error.

1. maybe because the GPS is broken (rare case)
2. or GPS is working with a delay (in this case trying a second time will mostly work. In my testing I was not getting this issue)
3. any internal issues with @react-native-community/geolocation library.

[kaushiktd]

Despite extensive testing on my end, I've encountered difficulties reproducing the same error within my local environment.
To provide further insight, here are the steps I've taken:
Emulating the conditions described.
Ensuring that permissions, configurations, and dependencies are identical to the production environment.
Attempting to replicate the scenario using various devices and platforms.
I've been unable to reproduce the issue, which suggests that there might be environmental or specific conditions in your setup that I'm not currently encountering.

Video:

https://drive.google.com/file/d/11sMDcQFbVdHdWdCJT8j09JqrqtdLAgAI/view?usp=sharing

[sakluger]

@kaushiktd what version of the app are you using? I was able to reproduce on Android native version 1.4.13.1:

[kaushiktd]

@sakluger my version was 1.4.12-0

And I also checked with version 1.4.13-2. Still not able to reproduce.
https://drive.google.com/file/d/168Tj_H2U01SSegZDB8kDOJ6hA2O5E4n_/view?usp=sharing

[melvin-bot]

@sakluger Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@sakluger Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

❌ There was an error making the offer to @kaushiktd for the Contributor role. The BZ member will need to manually hire the contributor.

[kaushiktd]

@sakluger @eVoloshchak so there was an error in making offer to me. Should I do anything from my side?

[sakluger]

@kaushiktd no action required on your end, I'll manually sent you an offer.

[kaushiktd]

@sakluger Thank you. Should I start working on PR then?

[amyevans]

@kaushiktd Yes!

[kaushiktd]

@amyevans PR is ready actually. See here,
#34007 (comment)

@eVoloshchak is assignee there. 🙂

[kaushiktd]

The PR is ready for review. @eVoloshchak Can you please check that?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Handle myLocation error in START #34007

If no regressions arise, payment will be issued on 2024-01-24. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @kaushiktd requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: there isn't a PR that introduced this bug, we're just changing the config value to allow for poor GPS connection
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: additional discussion isn't needed, this is an extreme edge case
• Determine if we should create a regression test for this bug.
  It's hard to reliably simulate a poor GPS connection on Android (I've had to use a basement), I don't think QA team would be able to do that

[sakluger]

Summarizing payment on this issue:

Contributor: @kaushiktd - $500, paid via Upwork
Contributor+: @eVoloshchak - $500, please request on Newdot

[JmillsExpensify]

$500 approved for @eVoloshchak based on summary above.