[HOLD for payment 2023-12-20] [$500] Compose-Tapping on request money deep link app crashes

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.11
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Launch app
2. From slack tap on the link https://staging.new.expensify.com/request/new/manual

Expected Result:

Tapping on request money deep link app must not crash.

Actual Result:

Tapping on request money deep link app crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6309943_1702351372494.crash.mp4

Bug6309943_1702351647217!cras.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0138e42333faa67e02
• Upwork Job ID: 1734531208461672448
• Last Price Increase: 2023-12-12
• Automatic offers:
• jjcoffee | Reviewer | 28042311
• Pujan92 | Contributor | 28042312

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0138e42333faa67e02

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @lakchote (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Crash on request money link opening

What is the root cause of that problem?

We are using an invalid const variable for the TopTab.Screen name. Regression from #28618
094cc2e

App/src/pages/iou/MoneyRequestSelectorPage.js

Lines 123 to 125 in 2d8523a

	<TopTab.Screen
	name={CONST.TAB.MANUAL}
	component={NewRequestAmountPage}

What changes do you think we should make in order to solve the problem?

Correct the CONST variables for the screens name or other occurances with CONST.TAB_REQUEST instead of CONST.TAB bcoz CONST.TAB.MANUAL and others are not available now and moved to TAB_REQUEST.
With that check and update all occurrences of wrong mapping.

Components that need to be checked are MoneyRequestSelectorPage, MoneyRequestAmountForm & MoneyRequestConfirmPage where we have the wrong mappings.

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Pujan92 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[lakchote]

@Pujan92 as it's a time-sensitive issue, please do a PR in a timely manner, thank you.

[Pujan92]

@Pujan92 as it's a time-sensitive issue, please do a PR in a timely manner, thank you.

Sure, will raise it soon.

[Pujan92]

@jjcoffee @lakchote PR is ready!

[kavimuru]

@Pujan92 Now we get app crash when tapping on the request money in the Fab in Android and iOS. Should the above mentioned PR will fix that too?

Crash.mp4

[Julesssss]

Hey @kavimuru I caused that issue and I fixed it here, staging should work again very soon

[stephanieelliott]

I'm working on testing this one

[joekaufmanexpensify]

@stephanieelliott I actually just re-tested this one here!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Compose-Tapping on request money deep link app crashes #32916

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment automatic offer (Contributor)
• @jjcoffee requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: Refactor the money request creation flow #28618
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: 094cc2e#r135490601
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Open a deeplink to: https://staging.new.expensify.com/request/new/manual
2. Verify that the app does not crash

Do we agree 👍 or 👎

[NicMendonca]

@jjcoffee @Pujan92 you've both been paid

[NicMendonca]

all set here!