Truncate long items in the SelectionList #32532

abzokhattab · 2023-12-05T22:53:23Z

Details

Fixed Issues

Tests

Verify that no errors appear in the JS console

Click on Profile -> workspaces -> Create a new workspace and modify the workspace name to be a long one
Click + > New chat > Room
Click Workspace
Verify that the long workspaces names are truncated and ending with ...

Besides the previous test, All lists using SelectionList should truncate long items.
We can check a few of each type (single selection and multiple selection) to make sure both list items are functioning correctly:

Profile->timezone
Profile -> Pronouns
Workspace -> Members
Workspace -> Members -> Invite
Workspace -> Settings -> currency

Offline tests

Click on Profile -> workspaces -> Create a new workspace and modify the workspace name to be a long one
Click + > New chat > Room
Click Workspace
Verify that the long workspaces names are truncated and ending with ...

Besides the previous test, All lists using SelectionList should truncate long items.
We can check a few of each type (single selection and multiple selection) to make sure both list items are functioning correctly:

Profile->timezone
Profile -> Pronouns
Workspace -> Members
Workspace -> Members -> Invite
Workspace -> Settings -> currency

QA Steps

Verify that no errors appear in the JS console

Click on Profile -> workspaces -> Create a new workspace and modify the workspace name to be a long one
Click + > New chat > Room
Click Workspace
Verify that the long workspaces names are truncated and ending with ...

Besides the previous test, All lists using SelectionList should truncate long items.
We can check a few of each type (single selection and multiple selection) to make sure both list items are functioning correctly:

Profile->timezone
Profile -> Pronouns
Workspace -> Members
Workspace -> Members -> Invite
Workspace -> Settings -> currency

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-12-05T22:53:27Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abzokhattab · 2023-12-05T22:55:36Z

hi @s77rt,

I added the numberOfLines=1 in both the item.text and the item.alternateText
and please notice that I didn't add the tooltip component so let me know if we need to add it.

s77rt · 2023-12-05T22:56:56Z

@abzokhattab Please add the tooltip. It should be similar to that of UserListItem

abzokhattab · 2023-12-05T23:06:38Z

Okay done, the screenshots were updated.

src/components/SelectionList/RadioListItem.js

s77rt · 2023-12-06T12:58:16Z

On Android the text does not take the full available space, but that bug is being worked on here #21219 thus it's not a blocker

s77rt · 2023-12-06T13:02:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

src/components/SelectionList/RadioListItem.js

src/components/SelectionList/BaseListItem.js

src/components/SelectionList/UserListItem.js

src/components/SelectionList/BaseListItem.js

s77rt · 2023-12-07T14:50:13Z

@abzokhattab Thanks!

s77rt

One last change

src/components/SelectionList/BaseListItem.js

iwiznia

The modified components are used in more places than the workspace list, right?
If so, can you add some tests to the description of the PR testing those other places please?
Then please ping me to merge this

abzokhattab · 2023-12-08T01:06:03Z

Okay @iwiznia I added some other tests.

OSBotify · 2023-12-08T01:14:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-11T10:44:52Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 1.4.11-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-13T11:09:31Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.11-25 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

s77rt · 2024-01-17T21:11:07Z

src/components/SelectionList/BaseListItem.js

+                            isUserItem || item.isSelected ? styles.sidebarLinkTextBold : null,
+                            styles.pre,
+                        ]}
+                        alternateTextStyles={[styles.optionAlternateText, styles.textLabelSupporting, isFocused ? styles.sidebarLinkActiveText : styles.sidebarLinkText, styles.pre]}


The order of styles matter. We used to have styles.textLabelSupporting passed last so a font size of 13px is applied. But now with the new order another font size is being applied. This caused a regression (partly) #32614

Oh, didn't notice it, should I create a PR to fix it?

This is fixed already

Truncate long items in the SelectionList

b39a8d6

abzokhattab requested a review from a team as a code owner December 5, 2023 22:53

melvin-bot bot removed the request for review from a team December 5, 2023 22:53

melvin-bot bot requested a review from s77rt December 5, 2023 22:53

Adding text tooltip

fc196c5

s77rt suggested changes Dec 6, 2023

View reviewed changes

src/components/SelectionList/RadioListItem.js Outdated Show resolved Hide resolved

abzokhattab force-pushed the truncate-long-items-in-the-selectionlist branch from 67285ec to fc196c5 Compare December 6, 2023 22:15

Passing ListItem text styles as props

53f7bac

abzokhattab requested a review from s77rt December 6, 2023 22:16

s77rt suggested changes Dec 6, 2023

View reviewed changes

src/components/SelectionList/RadioListItem.js Outdated Show resolved Hide resolved

src/components/SelectionList/BaseListItem.js Outdated Show resolved Hide resolved

Code refactoring

1a143a9

s77rt suggested changes Dec 7, 2023

View reviewed changes

src/components/SelectionList/BaseListItem.js Outdated Show resolved Hide resolved

src/components/SelectionList/UserListItem.js Outdated Show resolved Hide resolved

src/components/SelectionList/BaseListItem.js Show resolved Hide resolved

abzokhattab added 3 commits December 7, 2023 15:17

Renaming styles props

619481d

Refactoring

5be3074

Refactoring

89c11f8

abzokhattab requested a review from s77rt December 7, 2023 13:37

revert minor change

b1a49ed

s77rt suggested changes Dec 7, 2023

View reviewed changes

src/components/SelectionList/BaseListItem.js Show resolved Hide resolved

abzokhattab force-pushed the truncate-long-items-in-the-selectionlist branch from 835fe23 to b1a49ed Compare December 7, 2023 15:03

abzokhattab requested a review from s77rt December 7, 2023 15:03

s77rt approved these changes Dec 7, 2023

View reviewed changes

melvin-bot bot requested a review from iwiznia December 7, 2023 15:04

iwiznia approved these changes Dec 7, 2023

View reviewed changes

iwiznia merged commit 2aab3e8 into Expensify:main Dec 8, 2023
32 of 33 checks passed

github-actions bot mentioned this pull request Dec 11, 2023

Deploy Checklist: New Expensify 2023-12-11 #32794

Closed

81 tasks

melvin-bot bot mentioned this pull request Dec 13, 2023

[HOLD for payment 2023-12-20] [$500] Room - Long workspace name is not truncated in workspace selection page during room creation #32384

Closed

6 tasks

dukenv0307 mentioned this pull request Dec 15, 2023

[HOLD for payment 2024-01-24] [$500] Settings - Only top 10 timezones have tooltip #33172

Closed

6 tasks

s77rt reviewed Jan 17, 2024

View reviewed changes

s77rt mentioned this pull request Jan 17, 2024

[HOLD for payment 2024-01-17] [$500] HIGH: Improve formatting of People in this workspace can find your room message #32614

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Truncate long items in the SelectionList #32532

Truncate long items in the SelectionList #32532

abzokhattab commented Dec 5, 2023 •

edited

Loading

melvin-bot bot commented Dec 5, 2023

abzokhattab commented Dec 5, 2023

s77rt commented Dec 5, 2023

abzokhattab commented Dec 5, 2023

s77rt commented Dec 6, 2023

s77rt commented Dec 6, 2023 •

edited

Loading

s77rt commented Dec 7, 2023

s77rt left a comment

iwiznia left a comment

abzokhattab commented Dec 8, 2023

OSBotify commented Dec 8, 2023

OSBotify commented Dec 11, 2023

OSBotify commented Dec 13, 2023

s77rt Jan 17, 2024

abzokhattab Jan 17, 2024

iwiznia Jan 18, 2024

abzokhattab Jan 18, 2024

s77rt Jan 18, 2024

Truncate long items in the SelectionList #32532

Truncate long items in the SelectionList #32532

Conversation

abzokhattab commented Dec 5, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 5, 2023

abzokhattab commented Dec 5, 2023

s77rt commented Dec 5, 2023

abzokhattab commented Dec 5, 2023

s77rt commented Dec 6, 2023

s77rt commented Dec 6, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

s77rt commented Dec 7, 2023

s77rt left a comment

Choose a reason for hiding this comment

iwiznia left a comment

Choose a reason for hiding this comment

abzokhattab commented Dec 8, 2023

OSBotify commented Dec 8, 2023

OSBotify commented Dec 11, 2023

OSBotify commented Dec 13, 2023

s77rt Jan 17, 2024

Choose a reason for hiding this comment

abzokhattab Jan 17, 2024

Choose a reason for hiding this comment

iwiznia Jan 18, 2024

Choose a reason for hiding this comment

abzokhattab Jan 18, 2024

Choose a reason for hiding this comment

s77rt Jan 18, 2024

Choose a reason for hiding this comment

abzokhattab commented Dec 5, 2023 •

edited

Loading

s77rt commented Dec 6, 2023 •

edited

Loading