[Paid] Android - IOU - App crashes when adding a receipt from gallery in confirmation page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.11-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch New Expensify app
2. Go to 1:1 DM > + > Request money
3. Enter amount and proceed to confirmation page
4. Tap 3-dot menu > Add receipt
5. Upload a receipt from gallery

Expected Result:

App does not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309601_1702326171227.Screen_Recording_20231212_011607_New_Expensify.mp4

logs.txt

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JmillsExpensify

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @grgia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - IOU - App crashes when adding a receipt from gallery in confirmation page

What is the root cause of that problem?

App crashes on this line:

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 221 in 86a2521

_.some(participants, (participant) => participant.searchText.toLowerCase().includes(searchTerm.trim().toLowerCase())),

participant.searchText is undefined. Why?

After scanning receipt, there's no navigation goBack logic.

This doesn't happen when capture photo from camera because that logic is here:

App/src/pages/iou/request/step/IOURequestStepScan/index.native.js

Lines 138 to 141 in 86a2521

	if (backTo) {
	Navigation.goBack(backTo);
	return;
	}

What changes do you think we should make in order to solve the problem?

Apply same logic above to gallery picker:

App/src/pages/iou/request/step/IOURequestStepScan/index.native.js

Line 231 in 86a2521

This bug also happens on mWeb, when capture photo. The fix is same as above so add navigation goBack logic here:

App/src/pages/iou/request/step/IOURequestStepScan/index.js

Line 156 in 86a2521

similar to here: (document picker)

App/src/pages/iou/request/step/IOURequestStepScan/index.js

Lines 123 to 126 in 86a2521

	if (backTo) {
	Navigation.goBack(backTo);
	return;
	}

[luacmartins]

@mkhutornyi are you able to work on a PR within the next hour?

[mkhutornyi]

yes, I am

[mkhutornyi]

For speed-up, I can raise one PR for 2 issue fixes.
Here's another one - #32844 I found root cause & solution

[luacmartins]

Cool, assigned you to the issue. Let me know when the PR is ready

[luacmartins]

Tested in staging. This is a pass.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix receipt scan issues on mobile #32886

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mkhutornyi is contributor requires payment (Needs manual offer from BZ).
• @parasharrajat is C+ requires payment (Needs manual offer from BZ).

[melvin-bot]

@strepanier03, @luacmartins, @mkhutornyi Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[parasharrajat]

@strepanier03 This issue is completed and waiting on payments.

@mkhutornyi is a PR author.
@parasharrajat is C+.

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Refactor the money request creation flow #28618
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Refactor the money request creation flow #28618 (comment)
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed. Such issues are expected with major refactors. we should run regression steps against such PRs.
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Launch New Expensify app
2. Go to 1:1 DM > + > Request money
3. Enter amount and proceed to confirmation page
4. Tap 3-dot menu > Add receipt
5. Upload a receipt from gallery.
6. Observe that receipt is uploaded successfully.

Do you agree 👍 or 👎 ?

[melvin-bot]

@strepanier03, @luacmartins, @mkhutornyi Eep! 4 days overdue now. Issues have feelings too...

[strepanier03]

Been OoO but back in now. Working on payments.

[strepanier03]

Regression test made and bug checklist is done.

I've sent offers to both @parasharrajat and @mkhutornyi. I'll check back in tomorrow.

[strepanier03]

Waiting for offers to be accepted and then I'll pay out. I'll check again tomorrow.

[parasharrajat]

I will request it on NewDot later. Could you please post a summary here? Feel free to close the issue when you are done paying others. Thanks.

[melvin-bot]

@strepanier03, @luacmartins, @mkhutornyi Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

Got it, will do that shortly @parasharrajat.

[strepanier03]

@mkhutornyi - I've paid you in Upwork and closed the contract.

[strepanier03]

Payment Summary

• Contributor - @mkhutornyi $500 paid via Upwork
• C+ - @parasharrajat $500 to be paid via Manual Request

@JmillsExpensify - head's up, a request is incoming from Rajat.

[parasharrajat]

Payment requested as per #32865 (comment)

[parasharrajat]

@strepanier03 Could you please update the summary to include the amount?

[JmillsExpensify]

Re-opening so that I can get payment summaries with an amount.

[strepanier03]

Oops, sorry about that, don't know how I managed to forget that 🤦‍♀️. Updated the payment summary above with amounts.

[melvin-bot]

@JmillsExpensify, @strepanier03, @luacmartins, @mkhutornyi Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

Seems like we can close this again since the payment summary was updated. Please reopen if we're still missing something.

[JmillsExpensify]

$500 approved for @parasharrajat