Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-20] IOU - An error occurs when creating a Split Bill #32852

Closed
6 tasks done
lanitochka17 opened this issue Dec 11, 2023 · 19 comments
Closed
6 tasks done
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.11-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open New Expensify app
  2. Log in with any account
  3. Tap on the green plus button (FAB)
  4. Select Request money
  5. Select any currency and amount
  6. Click next
  7. Add multiple users to the Split Bill
  8. Complete the Split Bill

Expected Result:

No errors should occur when creating a Split Bill

Actual Result:

When creating Split Bill, the error "Unexpected error creating this chat, please try again later" appears and when it's removed, the IOU disappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309420_1702317783674.Recording__911.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @JmillsExpensify
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 11, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 11, 2023

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@tgolen
Copy link
Contributor

tgolen commented Dec 11, 2023

I'll take this. It's related to my recent refactoring

@abzokhattab
Copy link
Contributor

abzokhattab commented Dec 11, 2023

I think this one fixes the current issue: #32855 i get no errors on creating a split request

@tgolen
Copy link
Contributor

tgolen commented Dec 11, 2023

OK, thank you. Can you please link this issue in the PR as well (so it closes both issues)?

@Julesssss
Copy link
Contributor

@tgolen I believe it was this PR. I just added the link

@adelekennedy
Copy link

adelekennedy commented Dec 12, 2023

Just tested on staging 1.4.11-16 - split worked, no errors

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Dec 12, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Dec 13, 2023
@melvin-bot melvin-bot bot changed the title IOU - An error occurs when creating a Split Bill [HOLD for payment 2023-12-20] IOU - An error occurs when creating a Split Bill Dec 13, 2023
Copy link

melvin-bot bot commented Dec 13, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 20, 2023
Copy link

melvin-bot bot commented Dec 25, 2023

@tgolen Eep! 4 days overdue now. Issues have feelings too...

@tgolen tgolen added the Bug Something is broken. Auto assigns a BugZero manager. label Dec 26, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot removed the Overdue label Dec 26, 2023

This comment was marked as off-topic.

@tgolen
Copy link
Contributor

tgolen commented Dec 26, 2023

@JmillsExpensify could you please pay @shubham1206agra for their review of the PR?

@melvin-bot melvin-bot bot added the Overdue label Dec 28, 2023
Copy link

melvin-bot bot commented Jan 1, 2024

@JmillsExpensify, @tgolen Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Jan 2, 2024

@JmillsExpensify, @tgolen Still overdue 6 days?! Let's take care of this!

@JmillsExpensify
Copy link

Do we need a regression test on this one?

@melvin-bot melvin-bot bot removed the Overdue label Jan 3, 2024
@JmillsExpensify
Copy link

Payment summary: $500 to @shubham1206agra for PR testing and review.

@JmillsExpensify
Copy link

Offer sent!

@shubham1206agra
Copy link
Contributor

Accepted

@JmillsExpensify
Copy link

Thanks! All paid out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

9 participants