Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2023-06-16 #20928

Closed
OSBotify opened this issue Jun 16, 2023 · 74 comments
Closed

Deploy Checklist: New Expensify 2023-06-16 #20928

OSBotify opened this issue Jun 16, 2023 · 74 comments
Assignees
@luacmartins @applausebot
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jun 16, 2023 •
edited by luacmartins
Loading

Release Version: 1.3.29-11
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 16, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.29-0 🚀

@esh-g
Copy link
Contributor

esh-g commented Jun 16, 2023

Just a heads up, QA for the above PR will not be successful currently due to failure in a underlying method. But that will get fixed in #20934
After which I expect it work properly

@Beamanator
Copy link
Contributor

Beamanator commented Jun 18, 2023 •
edited
Loading

Checking off these since they're part of this bigger App PR (they weren't PRs into main):

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.29-1 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.29-1 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.29-2 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.29-2 has been deployed to staging 🎉

@luacmartins luacmartins self-assigned this Jun 19, 2023
@Julesssss
Copy link
Contributor

Julesssss commented Jun 19, 2023 •
edited
Loading

I don't believe #21037 is a blocker, so I removed the label and checked it off. But @luacmartins please review again in case anyone has been able to reproduce after I signed off (and we also think it. is important enough to block the release).

@mvtglobally
Copy link

Regression is completed

PR #20193 is failing #20950
PR #20223 is failing #20940
PR #20702 is failing #20969
PR #20706 is failing #20999
PR #20746 is failing #20970
PR #20750 is failing #20995
PR #20823 is failing #20803
PR #20826 is failing #20939
PR #20837, #21023,, #21026 testing

@Beamanator
Copy link
Contributor

Beamanator commented Jun 19, 2023 •
edited
Loading

Checking off #20971 b/c the fix was pushed to staging & tests passed on staging

@luacmartins luacmartins added the Daily KSv2 label Jun 19, 2023
@Beamanator
Copy link
Contributor

Also checking off #20970 since its fix should be on staging (see here)

@youssef-lr
Copy link
Contributor

Checked off #20819 as the fix has been deployed to staging and it tests well.

@marcaaron
Copy link
Contributor

Checking off #20955 as it is not reproducible on staging.

@NikkiWines
Copy link
Contributor

Checking off #20193 as it was a pass with the updated steps ✅

@luacmartins
Copy link
Contributor

Checking off #20826 since it's a pass on staging.

@luacmartins
Copy link
Contributor

Checking off #20823. It's a pass on staging.

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.29-3 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.29-3 has been deployed to staging 🎉

@luacmartins
Copy link
Contributor

Checking off #20962 since the fix is in Auth and we have a PR up for it

@luacmartins
Copy link
Contributor

Checking off #20961 since it's not reproducible on staging

@luacmartins
Copy link
Contributor

Checking off #21041 since it's expected for now and will be fixed in the next Auth deploy

@luacmartins
Copy link
Contributor

luacmartins commented Jun 19, 2023 •
edited
Loading

Checking off #20991 since this Auth PR seems to fix the issue.

@luacmartins
Copy link
Contributor

Checking off #20965 since https://github.com/Expensify/Auth/pull/8141 seems to fix the issue.

@luacmartins
Copy link
Contributor

luacmartins commented Jun 19, 2023 •
edited
Loading

Checking off #20969 since we merged this fix and are CPing it.

@luacmartins
Copy link
Contributor

Checking off #20746 since it's not reproducible

@luacmartins
Copy link
Contributor

Checking off #20706, based on this comment

@luacmartins
Copy link
Contributor

luacmartins commented Jun 20, 2023 •
edited
Loading

PR #20837, #21023,, #21026 testing

@mvtglobally were these PRs tested?

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.29-8 has been deployed to staging 🎉

@luacmartins
Copy link
Contributor

Checking off #20951. I tested on staging and it's a pass

@luacmartins
Copy link
Contributor

Checking off #21030. I tested on staging and it's a pass

@therealsujitk
Copy link
Contributor

therealsujitk commented Jun 20, 2023 •
edited
Loading

Might have found a deploy blocker - Slack Discussion, it's not reproducible by everyone though. I'm able to reproduce this in staging but not in production.

@luacmartins
Copy link
Contributor

Checking off #21081. I tested on staging and it's a pass.

@luacmartins
Copy link
Contributor

Checking off #21135. I tested on staging and couldn't reproduce the issue. Additionally, the PR is a pass and mentions are working again.

@Beamanator
Copy link
Contributor

Checking off #21113 b/c it's working well on Staging 👍

@mvtglobally
Copy link

PR #20837 is failing on web with #20961

@luacmartins
Copy link
Contributor

Checking off #20837. I tested on staging and it's a pass.

@luacmartins
Copy link
Contributor

Checking off #21127 since we merged a fix and are CPing it.

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.29-9 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.29-9 has been deployed to staging 🎉

@mountiny
Copy link
Contributor

Checking #21149 off since it was fixed by Auth deploy

@luacmartins
Copy link
Contributor

Checking off #20940 as per this comment

@luacmartins
Copy link
Contributor

Checking off #20966 as per this comment

@luacmartins
Copy link
Contributor

Checking off #21044 as per this comment

@luacmartins
Copy link
Contributor

Checking off #21002 as per this comment

@luacmartins
Copy link
Contributor

Checking off #21148 as per this comment

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.29-10 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.29-10 has been deployed to staging 🎉

@luacmartins
Copy link
Contributor

Checking off #20223 since we demoted the fix to not a blocker.

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.29-11 🚀

@luacmartins
Copy link
Contributor

Checking off #21150. I tested on staging and it's a pass.

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.29-11 has been deployed to staging 🎉

@luacmartins
Copy link
Contributor

Checking off #21159 and #21040. I tested on staging and it's a pass.

@luacmartins
Copy link
Contributor

Checklist is clear. Kicking off the deploy,

@luacmartins
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luacmartins luacmartins

@applausebot applausebot

Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests