[NO QA] Send logins in openReport API command #20547

Beamanator · 2023-06-09T19:16:30Z

Details

Although we recently thought it would be best to send accountIDs in the OpenReport request, this would result in many backend changes (mainly because we create closed accounts for new chats w/ brand new accounts, and we have weird authToken logic to get emails from closed account IDs)

Fixed Issues

$ related to #19007

Tests

Minimal tests here needed b/c we'll do full tests in the base branch

Make sure creating 1:1 & group chats still works
Attempt both with existing users & brand new users

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-06-09T19:17:02Z

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Beamanator · 2023-06-09T21:53:59Z

src/libs/OptionsListUtils.js

            showChatPreviewLine,
        });
+        userToInvite.isOptimisticAccount = true;


Not sure if this is needed anymore 🤔

No usages really. Only for backend?

…App into beaman-handleOptimisticReportCreation

BeeMargarida · 2023-06-12T10:29:40Z

LGTM 👍

0xmiros · 2023-06-12T10:45:18Z

Lint failing

Beamanator · 2023-06-12T10:46:26Z

@0xmiroslav thanks - fixed

0xmiros

console error after login new account

offline creating new chat seems broken. personal info missing / tons of console errors

Screen.Recording.2023-06-12.at.1.02.42.PM.mov

0xmiros · 2023-06-12T10:54:52Z

src/libs/OptionsListUtils.js

            showChatPreviewLine,
        });
+        userToInvite.isOptimisticAccount = true;


No usages really. Only for backend?

0xmiros · 2023-06-12T10:57:40Z

src/libs/PersonalDetailsUtils.js

+/**
+ * Given a list of logins, find the associated personal detail and return related accountIDs.
+ *
+ * @param {Array<string>} logins Array of user logins


NAB:

Suggested change

* @param {Array<string>} logins Array of user logins

* @param {Array<String>} logins Array of user logins

I see lots of String and string inconsistencies through the whole project

0xmiros · 2023-06-12T10:58:31Z

src/libs/PersonalDetailsUtils.js

+/**
+ * Given a list of accountIDs, find the associated personal detail and return related logins.
+ *
+ * @param {Array<number>} accountIDs Array of user accountIDs


Same here:

Suggested change

* @param {Array<number>} accountIDs Array of user accountIDs

* @param {Array<Number>} accountIDs Array of user accountIDs

0xmiros · 2023-06-12T11:17:41Z

Checklist (both Author and Reviewer) doesn't need to be filled?

Beamanator · 2023-06-12T11:18:42Z

@0xmiroslav thanks so much for the review, I'll make those updates in the base branch - and correct checklist isn't needed for this PR, will definitely be needed for base branch PR

OSBotify · 2023-06-16T18:52:19Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.29-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-21T02:19:50Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.29-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Beamanator added 4 commits June 9, 2023 12:37

Add optimistic data to options

ec1e2f5

Separate optimistic account data in openReport function

f5d92e0

Pass optimistic accounts to openReport

38ff349

Add placeholder params and TODOs

799dd86

Beamanator requested a review from a team as a code owner June 9, 2023 19:16

Beamanator changed the base branch from main to personalDetailsList-migration June 9, 2023 19:16

melvin-bot bot requested review from amyevans and removed request for a team June 9, 2023 19:17

Send only login list to backend for opening report

85479fd

Beamanator commented Jun 9, 2023

View reviewed changes

Beamanator added 4 commits June 9, 2023 17:55

Fix openReport use

c59de73

Update personal detail utils

f71c7e4

Use correct var

97114d8

Merge branch 'personalDetailsList-migration' of github.com:Expensify/…

37050f7

…App into beaman-handleOptimisticReportCreation

Use new var

2ac7d95

Beamanator changed the title ~~Handle optimistic report creation~~ Send logins in openReport API command Jun 12, 2023

Beamanator requested a review from 0xmiros June 12, 2023 10:43

prettify

a602bc2

Beamanator changed the title ~~Send logins in openReport API command~~ [NO QA] Send logins in openReport API command Jun 12, 2023

0xmiros reviewed Jun 12, 2023

View reviewed changes

Beamanator merged commit f8d8a87 into personalDetailsList-migration Jun 12, 2023

Beamanator deleted the beaman-handleOptimisticReportCreation branch June 12, 2023 11:18

OSBotify mentioned this pull request Jun 16, 2023

Deploy Checklist: New Expensify 2023-06-16 #20928

Closed

0xmiros mentioned this pull request Jul 26, 2023

[HOLD for payment 2023-06-28] [Secure Logins] Replace login uses with accountIDs throughout App (when accessing Onyx) #19007

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NO QA] Send logins in openReport API command #20547

[NO QA] Send logins in openReport API command #20547

Beamanator commented Jun 9, 2023 •

edited

Loading

melvin-bot bot commented Jun 9, 2023

Beamanator Jun 9, 2023

0xmiros Jun 12, 2023

BeeMargarida commented Jun 12, 2023

0xmiros commented Jun 12, 2023

Beamanator commented Jun 12, 2023

0xmiros left a comment

0xmiros Jun 12, 2023

0xmiros Jun 12, 2023

0xmiros Jun 12, 2023

0xmiros commented Jun 12, 2023

Beamanator commented Jun 12, 2023

OSBotify commented Jun 16, 2023

OSBotify commented Jun 21, 2023

	* @param {Array<string>} logins Array of user logins
	* @param {Array<String>} logins Array of user logins

	* @param {Array<number>} accountIDs Array of user accountIDs
	* @param {Array<Number>} accountIDs Array of user accountIDs

[NO QA] Send logins in openReport API command #20547

[NO QA] Send logins in openReport API command #20547

Conversation

Beamanator commented Jun 9, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 9, 2023

Beamanator Jun 9, 2023

Choose a reason for hiding this comment

0xmiros Jun 12, 2023

Choose a reason for hiding this comment

BeeMargarida commented Jun 12, 2023

0xmiros commented Jun 12, 2023

Beamanator commented Jun 12, 2023

0xmiros left a comment

Choose a reason for hiding this comment

0xmiros Jun 12, 2023

Choose a reason for hiding this comment

0xmiros Jun 12, 2023

Choose a reason for hiding this comment

0xmiros Jun 12, 2023

Choose a reason for hiding this comment

0xmiros commented Jun 12, 2023

Beamanator commented Jun 12, 2023

OSBotify commented Jun 16, 2023

OSBotify commented Jun 21, 2023

Beamanator commented Jun 9, 2023 •

edited

Loading