Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] [HOLD for payment 2023-06-29] Web - Split Bill - Details page is shown empty for old group chat splits #21044

Closed
1 of 6 tasks
kbecciv opened this issue Jun 19, 2023 · 29 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Jun 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to staging dot on web chrome
  2. Go to any old group chat where you splitted the bill (Important- split bill report)
  3. Click on it and notice that details page is empty
  4. But if you split the bill now in the same group and then click on the split bill report, you'll be able to see the details without any problem. Thus the problem occurs for old split bills and not the new ones.

Expected Result:

Details page should be not shown empty for old group chat splits

Actual Result:

Details page is shown empty for old group chat splits

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.29.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

green-2023-06-19_15.13.45.mp4
Recording.3156.mp4

Expensify/Expensify Issue URL:

Issue reported by: @priya-zha

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687167180014059

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01034e11a536cbe311
  • Upwork Job ID: 1673377762610040832
  • Last Price Increase: 2023-06-26
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jun 19, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@roryabraham
Copy link
Contributor

The problem here is that we changed the shape of reportActions data to go from originalMessage.participants -> originalMessage.participantAccountIDs and didn't migrate old reportActions...

@aldo-expensify
Copy link
Contributor

I chatted with Alex. B about this and it seems like we didn't migrate the database data. I'll try to prepare a CQ query to migrate.

@luacmartins
Copy link
Contributor

Removing the blocker label as per this comment

@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jun 20, 2023
@luacmartins
Copy link
Contributor

This was fixed, CPed and deployed to prod. No payments are due. Closing.

@priya-zha
Copy link

@luacmartins I'm the external reporter for this issue.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 22, 2023
@melvin-bot melvin-bot bot changed the title Web - Split Bill - Details page is shown empty for old group chat splits [HOLD for payment 2023-06-29] Web - Split Bill - Details page is shown empty for old group chat splits Jun 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@luacmartins
Copy link
Contributor

Sorry, I missed that @priya-zha. Reopening and adding Bug label to get payment sorted out.

@luacmartins luacmartins reopened this Jun 23, 2023
@luacmartins luacmartins added the Bug Something is broken. Auto assigns a BugZero manager. label Jun 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 23, 2023

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 23, 2023
@melvin-bot

This comment was marked as off-topic.

@luacmartins
Copy link
Contributor

@johncschuster we just need to pay the reporting bonus to @priya-zha

@melvin-bot melvin-bot bot added the Overdue label Jun 26, 2023
@luacmartins
Copy link
Contributor

Just missing reporting bonus payment to @priya-zha

@melvin-bot melvin-bot bot removed the Overdue label Jun 26, 2023
@johncschuster
Copy link
Contributor

Thanks for the callout, @luacmartins! I'll have a job created so I can pay the reporting bonus.

@johncschuster johncschuster added the External Added to denote the issue can be worked on by a contributor label Jun 26, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-06-29] Web - Split Bill - Details page is shown empty for old group chat splits [$1000] [HOLD for payment 2023-06-29] Web - Split Bill - Details page is shown empty for old group chat splits Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01034e11a536cbe311

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@johncschuster
Copy link
Contributor

Sorry for the ping, @mollfpr. I applied the External label just to create the Upwork job to pay the reporting bonus.

@johncschuster
Copy link
Contributor

@priya-zha, can you apply for the job above?

@priya-zha
Copy link

@johncschuster proposal submitted. thanks

@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

📣 @mentamarindos! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@lealobanov
Copy link

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0187e5647dc5b9d97e

@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

📣 @phoenixdevguru! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@johncschuster
Copy link
Contributor

Hi @phoenixdevguru, this issue has already been resolved. We're just working on issuing payment to the bug reporter.

@johncschuster
Copy link
Contributor

Payment has been issued! I think we're good to close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

10 participants