Add Mark as Read/Unread option to LHN Context menu #20254

Gonals · 2023-06-06T10:52:15Z

Details

Fixed Issues

$ #20249

Tests

Log into NewDot
On the LHN, right click/long press on top of a read chat.
A menu with the Mark as unread option should show up. Press it
Confirm it gets marked as Unread
Do the same for an unread chat and confirm you can mark it as read
Open a chat and right click/long press one of the messages. Confirm the usual menu shows up as usual and it doesn't have the Mark as Read option (The Mark as Unread one should be there).

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-06-06T10:52:50Z

@0xmiroslav @luacmartins One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Gonals · 2023-06-06T10:59:17Z

Ready for review! iOS is still being a pain for me. @0xmiroslav, can you take a look? 😁

0xmiros · 2023-06-06T11:03:26Z

src/libs/actions/Report.js

-function markCommentAsUnread(reportID, reportActionCreated) {
+function markCommentAsUnread(reportID, reportActionCreated = '') {
+    // If no action created date is provided, use the last action's
+    const actionCreationTime = reportActionCreated || allReports[reportID].lastVisibleActionCreated;


reportActionCreated = ''
Do we need empty string as default value? This is always ignored in this condition: reportActionCreated ||.
And for null safety, use lodashGet for allReports[reportID].lastVisibleActionCreated.

And need to check if DateUtils.subtractMillisecondsFromDateTime(undefined, 1) returns current time or any other weird value.

Agree that we should use lodashGet here and maybe default to the current timestamp if we can't find anything.

I guess you are right. removed the default.

And need to check if DateUtils.subtractMillisecondsFromDateTime(undefined, 1) returns current time or any other weird value.

Current time!

luacmartins · 2023-06-06T15:52:30Z

src/libs/actions/Report.js

-function markCommentAsUnread(reportID, reportActionCreated) {
+function markCommentAsUnread(reportID, reportActionCreated = '') {
+    // If no action created date is provided, use the last action's
+    const actionCreationTime = reportActionCreated || allReports[reportID].lastVisibleActionCreated;


Agree that we should use lodashGet here and maybe default to the current timestamp if we can't find anything.

Gonals · 2023-06-08T10:54:17Z

Comments addressed!

src/components/LHNOptionsList/OptionRowLHN.js

Gonals · 2023-06-13T08:38:14Z

OFF HOLD and ready!

luacmartins

LGTM! @0xmiroslav all yours

0xmiros

LGTM2. One minor thing:

0xmiros · 2023-06-13T16:44:15Z

src/languages/en.js

@@ -266,6 +266,7 @@ export default {
        copyURLToClipboard: 'Copy URL to clipboard',
        copyEmailToClipboard: 'Copy email to clipboard',
        markAsUnread: 'Mark as unread',
+        markAsRead: 'Mark as Read',


Suggested change

markAsRead: 'Mark as Read',

markAsRead: 'Mark as read',

ah nice catch. Yea let's address that @Gonals

luacmartins · 2023-06-14T18:06:02Z

@Gonals just missing this comment

Gonals · 2023-06-15T15:11:58Z

Done!

luacmartins

LGTM

Gonals · 2023-06-16T03:02:17Z

All yours @0xmiroslav

0xmiros · 2023-06-16T03:46:54Z

Mark as unread doesn't work well in thread. This can be out of scope since same issue happens on unread button from mini context menu.
Reproduction step:

Go to any chat and send message
Thread that message
Mark as unread
Unread indicator shows above parent message (works this time)
Send any message in thread and then delete
Mark as unread again
Unread indicator doesn't show (doesn't work this time)

unread.indicator.bug.mov

0xmiros · 2023-06-16T03:53:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

0xmiros

LGTM2!

melvin-bot · 2023-06-16T03:53:35Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #20249... Please reach out for help on Slack if no one gets assigned!

OSBotify · 2023-06-16T15:29:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-16T18:50:19Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.29-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-21T02:17:50Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.29-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Gonals added 5 commits June 6, 2023 11:06

Add new context actions

1e1c490

use last action for Mark as unread

cd7857d

pass prop all over

4f9efb0

Add text and use right action

6a9ac4f

hide menu when the state changes

61a87b5

Gonals requested a review from a team as a code owner June 6, 2023 10:52

Gonals self-assigned this Jun 6, 2023

melvin-bot bot requested review from 0xmiros and luacmartins and removed request for a team June 6, 2023 10:52

prettier

afcdc74

0xmiros reviewed Jun 6, 2023

View reviewed changes

luacmartins requested changes Jun 6, 2023

View reviewed changes

Gonals added 3 commits June 7, 2023 11:09

Merge branch 'main' into alberto-read

0adbf83

Remove conditional

b1c7dcd

use lodashget

9365efb

luacmartins previously approved these changes Jun 7, 2023

View reviewed changes

Merge branch 'main' into alberto-read

0fd9612

0xmiros reviewed Jun 8, 2023

View reviewed changes

src/components/LHNOptionsList/OptionRowLHN.js Outdated Show resolved Hide resolved

Gonals changed the title ~~Add Mark as Read/Unread option to LHN Context menu~~ [HOLD] Add Mark as Read/Unread option to LHN Context menu Jun 8, 2023

Gonals changed the title ~~[HOLD] Add Mark as Read/Unread option to LHN Context menu~~ Add Mark as Read/Unread option to LHN Context menu Jun 13, 2023

conflicts

85da9c0

Gonals dismissed luacmartins’s stale review via 85da9c0 June 13, 2023 08:22

luacmartins previously approved these changes Jun 13, 2023

View reviewed changes

0xmiros reviewed Jun 13, 2023

View reviewed changes

Gonals added 2 commits June 15, 2023 17:11

Merge branch 'main' into alberto-read

1542eb2

capital

79046eb

Gonals dismissed luacmartins’s stale review via 79046eb June 15, 2023 15:11

luacmartins approved these changes Jun 15, 2023

View reviewed changes

0xmiros approved these changes Jun 16, 2023

View reviewed changes

luacmartins merged commit edf529e into main Jun 16, 2023

luacmartins deleted the alberto-read branch June 16, 2023 15:26

OSBotify mentioned this pull request Jun 16, 2023

Deploy Checklist: New Expensify 2023-06-16 #20928

Closed

Ollyws mentioned this pull request Jun 20, 2023

Fix for: IOU has pin option in LHN #20771

Merged

57 tasks

melvin-bot bot mentioned this pull request Jun 21, 2023

[HOLD for payment 2023-06-28] Allow Mark as Read/Unread from LHN #20249

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Mark as Read/Unread option to LHN Context menu #20254

Add Mark as Read/Unread option to LHN Context menu #20254

Gonals commented Jun 6, 2023 •

edited

Loading

melvin-bot bot commented Jun 6, 2023

Gonals commented Jun 6, 2023

0xmiros Jun 6, 2023

luacmartins Jun 6, 2023

Gonals Jun 7, 2023

luacmartins Jun 6, 2023

Gonals commented Jun 8, 2023

Gonals commented Jun 13, 2023

luacmartins left a comment

0xmiros left a comment

0xmiros Jun 13, 2023

luacmartins Jun 13, 2023 •

edited

Loading

Gonals Jun 15, 2023

luacmartins commented Jun 14, 2023

Gonals commented Jun 15, 2023

luacmartins left a comment

Gonals commented Jun 16, 2023

0xmiros commented Jun 16, 2023

0xmiros commented Jun 16, 2023

0xmiros left a comment

melvin-bot bot commented Jun 16, 2023

OSBotify commented Jun 16, 2023

OSBotify commented Jun 16, 2023

OSBotify commented Jun 21, 2023

Add Mark as Read/Unread option to LHN Context menu #20254

Add Mark as Read/Unread option to LHN Context menu #20254

Conversation

Gonals commented Jun 6, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 6, 2023

Gonals commented Jun 6, 2023

0xmiros Jun 6, 2023

Choose a reason for hiding this comment

luacmartins Jun 6, 2023

Choose a reason for hiding this comment

Gonals Jun 7, 2023

Choose a reason for hiding this comment

luacmartins Jun 6, 2023

Choose a reason for hiding this comment

Gonals commented Jun 8, 2023

Gonals commented Jun 13, 2023

luacmartins left a comment

Choose a reason for hiding this comment

0xmiros left a comment

Choose a reason for hiding this comment

0xmiros Jun 13, 2023

Choose a reason for hiding this comment

luacmartins Jun 13, 2023 • edited Loading

Choose a reason for hiding this comment

Gonals Jun 15, 2023

Choose a reason for hiding this comment

luacmartins commented Jun 14, 2023

Gonals commented Jun 15, 2023

luacmartins left a comment

Choose a reason for hiding this comment

Gonals commented Jun 16, 2023

0xmiros commented Jun 16, 2023

0xmiros commented Jun 16, 2023

Reviewer Checklist

Screenshots/Videos

0xmiros left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jun 16, 2023

OSBotify commented Jun 16, 2023

OSBotify commented Jun 16, 2023

OSBotify commented Jun 21, 2023

Gonals commented Jun 6, 2023 •

edited

Loading

luacmartins Jun 13, 2023 •

edited

Loading