"__fake__" appears on LHN after flagging a content

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Start a new conversation from account A to account B (There should be no comment before the comment that is about to be flagged)
2. Flag the message sent from account B as either "harassment" or "Assault"
3. Observe the LHN

Expected Result:

"fake" should not appear on the LHN

Actual Result:

"fake" appears on LHN

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.995.mp4

Recording.996.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686941708297639

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[aldo-expensify]

I think this fixes it: #20949

[sakluger]

Thanks for the quick work Aldo. Let me know if I can help in any way.

[aldo-expensify]

During the PR #20949 review we found quite a few other cases that were not working:

• [FIXED] Missing offline behaviour: [HOLD] Don't use CREATED action as last message for LHN #20949 (comment)
• [FIXED] Groups/Tasks not working correctly: [HOLD] Don't use CREATED action as last message for LHN #20949 (comment), [HOLD] Don't use CREATED action as last message for LHN #20949 (comment)
• Wrong comment author for last message (LHN): [HOLD] Don't use CREATED action as last message for LHN #20949 (comment)
• Wrong attachment last message: [HOLD] Don't use CREATED action as last message for LHN #20949 (comment)
• Flagged comment shows in LHN if you don't open the report loading report actions: [HOLD] Don't use CREATED action as last message for LHN #20949 (comment)

Slack conversation: https://expensify.slack.com/archives/C03TQ48KC/p1687203338251969

Current plan to fix it: https://expensify.slack.com/archives/C07J32337/p1687204905234929?thread_ts=1687190085.248999&cid=C07J32337

[Beamanator]

FYI I also see __fake__ appear in LHN after creating a new group with a user I don't know yet / doesn't have a real account yet

• Found while testing steps from [HOLD for payment 2023-06-29] Selecting/removing one user selects/removes all the user on split bill group page #21075

Update: ^ was only found in staging, not on main

[luacmartins]

Gonna remove the blocker label as per this comment

[aldo-expensify]

To finish this, the following PR's will be needed:

• Auth: https://github.com/Expensify/Auth/pull/8170
• Web: https://github.com/Expensify/Web-Expensify/pull/37910
• App: [HOLD] Don't use CREATED action as last message for LHN #20949

[aldo-expensify]

Made backend PRs ready for review.

[aldo-expensify]

I merged the Auth PR, after it gets deployed, I'll merge Web-E, and after Web-E gets deployed, we can tell the C+ to retest the App PR.

[melvin-bot]

@sakluger @aldo-expensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[lschurr]

I believe this will also be fixed as a result of the PR: #22386

[aldo-expensify]

I just update the Web-E PR and made it ready for review again: https://github.com/Expensify/Web-Expensify/pull/37910

I believe this will also be fixed as a result of the PR: #22386

Maybe! I think we can check after the PRs for this issue have been merged

[Nathan-Mulugeta]

Hey guys, this issue has been fixed but payment has not been proceed for it. @lschurr @aldo-expensify @sakluger

[aldo-expensify]

Hey guys, this issue has been fixed but payment has not been proceed for it. @lschurr @aldo-expensify @sakluger

True, I retested and this is working now:

[aldo-expensify]

@sakluger we have to handle the reporting bonus for @Nathan-Mulugeta

[Nathan-Mulugeta]

Bump @sakluger

[Nathan-Mulugeta]

Bump @sakluger again 😄

[sakluger]

Sorry for the delay, just sent an offer to @Nathan-Mulugeta on Upwork.

[sakluger]

Switching to a daily to reflect the priority.

[Nathan-Mulugeta]

Thanks @sakluger , just accepted the offer.

[sakluger]

All paid up! Sorry again for the delay on payment @Nathan-Mulugeta.