Continue `personalDetails` -> `personalDetailsList` migration #20328

Beamanator · 2023-06-06T22:26:21Z

Details

Removing old key so that we're FORCED to start fixing issues as they come up. It's fine to break this branch, we'll come back to fix everything once we're much closer to the migration being complete

Fixed Issues

$ Related to #19007

Tests

N/A - This is definitely going to break things, we'll fix them as they come up

Offline tests

N/A - This is definitely going to break things, we'll fix them as they come up

QA Steps

N/A - This is definitely going to break things, we'll fix them as they come up

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-06-06T22:26:52Z

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

madmax330 · 2023-06-07T06:34:26Z

Lmk when this is ready, let's also get a C+ on the review since it's a large PR.

Beamanator · 2023-06-07T14:49:49Z

Yo @madmax330 - I thinkkkk we don't need a C+ to test this specific one since we're merging into a different branch.

I'm planning to get a lot of changes into the branch personalDetailsList-migration, then we do a TON of testing before merging that branch into main.

Tests fixed for "beaman-continueMigration" branch

fix: fixing failing tests for `OptionsListUtils` and `ReportUtils` suites

…nto beaman-continueMigration

Beamanator · 2023-06-07T17:28:47Z

#20371 got merged into this one & I added a few commits, but there's a "GH incident" affecting PRs, so not sure if we'll have to do some cleanup eventually 🙃

Policy members keyed by accountID

…App into beaman-continueMigration

…nto beaman-continueMigration

puneetlath · 2023-06-08T16:54:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Beamanator · 2023-06-08T16:56:08Z

src/CONST.js

+        QA: Number(lodashGet(Config, 'EXPENSIFY_ACCOUNT_ID_QA', 3126513)),
+        QA_TRAVIS: Number(lodashGet(Config, 'EXPENSIFY_ACCOUNT_ID_QA_TRAVIS', 8595733)),
+        RECEIPTS: Number(lodashGet(Config, 'EXPENSIFY_ACCOUNT_ID_RECEIPTS', -1)),
+        REWARDS: Number(lodashGet(Config, 'EXPENSIFY_ACCOUNT_ID_REWARDS', 11023767)), // [email protected]


Not sure if we need this? I think yes, but it's not in CONST.EMAIL at the moment 🤷

Beamanator · 2023-06-08T16:56:35Z

src/ONYXKEYS.js

@@ -114,6 +111,7 @@ export default {
        DOWNLOAD: 'download_',
        POLICY: 'policy_',
        POLICY_MEMBER_LIST: 'policyMemberList_',


I wonder if we can remove this now?

I'm not quite done migrating to the new key so IMO we should leave it until that's done.

Giggidy 👍

Beamanator · 2023-06-08T17:18:36Z

@puneetlath @neil-marcellini do y'all want to do a mini review before we merge this?

neil-marcellini

I'm blindly approving so we can start doing bug fixes on the main feature branch.

neil-marcellini · 2023-06-08T17:24:28Z

Reviewer Checklist

N/A but here it is

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

N/A

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

OSBotify · 2023-06-16T18:52:34Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.29-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-21T02:20:04Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.29-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allroundexperts · 2023-07-31T02:47:44Z

src/libs/UserUtils.js

 * @returns {String}
 */
-function getDefaultAvatar(login = '') {
-    if (!login) {
+function getDefaultAvatar(accountID = -1) {


Getting default avatar based on accountID introduced #22085 since accountID always changes for new users.

sobitneupane · 2023-08-09T05:18:46Z

#22659 issue was caused by this PR. 'Hidden' was not translated to Spanish language. We should have used translation key instead of constant for 'Hidden'.

allroundexperts · 2023-12-19T11:34:24Z

src/components/ReportActionItem/IOUPreview.js

+    const sessionAccountID = lodashGet(props.session, 'accountID', null);
+    const managerID = props.iouReport.managerID || '';
+    const ownerAccountID = props.iouReport.ownerAccountID || '';
+    const participantAccountIDs = props.isBillSplit ? lodashGet(props.action, 'originalMessage.participantAccountIDs', []) : [managerID, ownerAccountID];


We should have sorted the account ids. Not doing so resulted in #31732

jjcoffee · 2024-01-02T10:22:27Z

src/libs/UserUtils.js

 * @returns {String}
 */
-function getDefaultAvatar(login = '') {
-    if (!login) {
+function getDefaultAvatar(accountID = -1) {


Switching to using the accountID to get a default avatar caused #28518 as we use an optimistic accountID when chatting with new users.

Remove all uses of old personalDetails onyx key

b94183a

Beamanator requested a review from a team as a code owner June 6, 2023 22:26

melvin-bot bot removed the request for review from a team June 6, 2023 22:26

melvin-bot bot requested a review from madmax330 June 6, 2023 22:26

Beamanator added 5 commits June 6, 2023 18:39

Use accountID to get avatars

7a95a3a

Update to new function name

410cb62

Migrate email to accountID where possible

7f0a66d

Update a few tests with accountID-keyed details

54ecbcb

Fix lots of accountID tests

b9d30ef

burczu and others added 4 commits June 7, 2023 12:47

SidebarFilterTest fixed

e5bc39b

SidebarOrderTest fixed

d547dab

JSDoc fixed

588cb20

fix: start migration for getSearchOptions, getOptions and createOption

ef3d955

Beamanator and others added 12 commits June 7, 2023 10:50

Merge pull request #20351 from burczu/beaman-continueMigration-fork

e8b7f86

Tests fixed for "beaman-continueMigration" branch

fix: complete migration of some report utils to accountID

5c395d0

fix: generate random accountID for users info not in Onyx

5f5789b

Merge branch 'beaman-continueMigration' into migration-OptionsListUtils

8261127

New util to default displayName to hidden if unavailable

f18dd6c

fix: update ReportUtils to use accountID and fix tests

cf0b245

fix: add notes and fix small issues

9d30f05

style: prettier

3ca4e0d

Merge pull request #20371 from BeeMargarida/migration-OptionsListUtils

fde3aff

fix: fixing failing tests for `OptionsListUtils` and `ReportUtils` suites

Update a few tests

156deff

Merge branch 'beaman-continueMigration' of github.com:Expensify/App i…

fe62c42

…nto beaman-continueMigration

Clean up session key subscription

9a70430

Add new policy members key

f376593

Beamanator added 9 commits June 7, 2023 21:58

Many iOU updates

1e97491

Merge pull request #20397 from Expensify/neil-collection-policy-members

dde8e89

Policy members keyed by accountID

Merge branch 'personalDetailsList-migration' of github.com:Expensify/…

f3745b6

…App into beaman-continueMigration

Merge branch 'beaman-continueMigration' of github.com:Expensify/App i…

b419252

…nto beaman-continueMigration

More iOU updates

fe3d585

A bit of cleanup

3754886

Many task edits

7fe728c

Fix iOU test and more migration

69939e8

Fix reportUtilsTest

79cca49

puneetlath assigned Beamanator Jun 8, 2023

Beamanator commented Jun 8, 2023

View reviewed changes

neil-marcellini approved these changes Jun 8, 2023

View reviewed changes

neil-marcellini merged commit 1762fbe into personalDetailsList-migration Jun 8, 2023

neil-marcellini deleted the beaman-continueMigration branch June 8, 2023 17:33

OSBotify mentioned this pull request Jun 16, 2023

Deploy Checklist: New Expensify 2023-06-16 #20928

Closed

tienifr mentioned this pull request Jul 10, 2023

[$1000] Primary login account is added to split bill participant list and amount also gets divided changing default contact method #19981

Closed

6 tasks

allroundexperts reviewed Jul 31, 2023

View reviewed changes

allroundexperts mentioned this pull request Jul 31, 2023

[HOLD for payment 2023-07-28] [$1000] Web -Default avatar is changed when we select/unselect a member in Workspace invitation page #22085

Closed

6 tasks

sobitneupane mentioned this pull request Aug 9, 2023

[HOLD for payment 2023-08-03] [$1000] Text 'Hidden' in Details Page does not change language when updating language to Spanish #22659

Closed

6 tasks

allroundexperts reviewed Dec 19, 2023

View reviewed changes

allroundexperts mentioned this pull request Dec 19, 2023

[Awaiting Payment - 22nd Dec] [$500] User Account Swapping Issue in IOU When Splitting Bills #31732

Closed

6 tasks

jjcoffee reviewed Jan 2, 2024

View reviewed changes

jjcoffee mentioned this pull request Jan 2, 2024

[HOLD for payment 2023-12-28] [$500] Chat - Avatar of a new user changes when switching from offline to online #28518

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Continue `personalDetails` -> `personalDetailsList` migration #20328

Continue `personalDetails` -> `personalDetailsList` migration #20328

Beamanator commented Jun 6, 2023 •

edited

Loading

melvin-bot bot commented Jun 6, 2023

madmax330 commented Jun 7, 2023

Beamanator commented Jun 7, 2023

Beamanator commented Jun 7, 2023

puneetlath commented Jun 8, 2023

Beamanator Jun 8, 2023

Beamanator Jun 8, 2023

neil-marcellini Jun 8, 2023

Beamanator Jun 8, 2023

Beamanator commented Jun 8, 2023

neil-marcellini left a comment

neil-marcellini commented Jun 8, 2023

OSBotify commented Jun 16, 2023

OSBotify commented Jun 21, 2023

allroundexperts Jul 31, 2023

sobitneupane commented Aug 9, 2023 •

edited

Loading

allroundexperts Dec 19, 2023

jjcoffee Jan 2, 2024

Continue personalDetails -> personalDetailsList migration #20328

Continue personalDetails -> personalDetailsList migration #20328

Conversation

Beamanator commented Jun 6, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 6, 2023

madmax330 commented Jun 7, 2023

Beamanator commented Jun 7, 2023

Beamanator commented Jun 7, 2023

puneetlath commented Jun 8, 2023

Reviewer Checklist

Screenshots/Videos

Beamanator Jun 8, 2023

Choose a reason for hiding this comment

Beamanator Jun 8, 2023

Choose a reason for hiding this comment

neil-marcellini Jun 8, 2023

Choose a reason for hiding this comment

Beamanator Jun 8, 2023

Choose a reason for hiding this comment

Beamanator commented Jun 8, 2023

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini commented Jun 8, 2023

Reviewer Checklist

Screenshots/Videos

OSBotify commented Jun 16, 2023

OSBotify commented Jun 21, 2023

allroundexperts Jul 31, 2023

Choose a reason for hiding this comment

sobitneupane commented Aug 9, 2023 • edited Loading

allroundexperts Dec 19, 2023

Choose a reason for hiding this comment

jjcoffee Jan 2, 2024

Choose a reason for hiding this comment

Continue `personalDetails` -> `personalDetailsList` migration #20328

Continue `personalDetails` -> `personalDetailsList` migration #20328

Beamanator commented Jun 6, 2023 •

edited

Loading

sobitneupane commented Aug 9, 2023 •

edited

Loading