[HOLD for payment 2023-06-29] App crashes when trying to use mention @

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. In the compose box type @ to mention

Expected Result:

List of emails should popup

Actual Result:

App crashed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.998.mp4

Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0106cd32b2d6c18034
• Upwork Job ID: 1674284198851424256
• Last Price Increase: 2023-06-29

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when trying to use mention

What is the root cause of that problem?

Server seems to be sending user details without login property when creating a new chat with email containing an uppercase letter.

This is causing the alternateText property of the mention object to be undefined. As such, the crash happens here.

What changes do you think we should make in order to solve the problem?

We should fix this on the server but on the frontend, we should add a default value of "" to the name param of the getStyledTextArray function here.

What alternative solutions did you explore? (Optional)

We can also replace this with:

        const styledHandle = item.alternateText ? getStyledTextArray(item.alternateText, props.prefix) : [];

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kadiealexander]

@abekkala I'm heading OOO so reassigning this to make sure it's looked after while I'm gone. If it's still open when I'm back next Monday I'll take it back!

[MonilBhavsar]

We wouldn't send login(email) now for all accounts, so we need to adjust mentions logic to use display name if it is set

[luacmartins]

We merged a fix. Removing the label. Gonna keep this issue open to process payment.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Mentions crash #21030

If no regressions arise, payment will be issued on 2023-06-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@MonilBhavsar] Determine if we should create a regression test for this bug.
• [@MonilBhavsar] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MonilBhavsar]

I believe that @allroundexperts's proposal might still be necessary. I see a few Crashlytics reports, like the one below:

@luacmartins that's weird, It shouldn't happen. Where do we see this? Is it happening frequently for all users or people on old app

[luacmartins]

I haven't seen it on the latest staging version, so maybe it was fixed. I'll come back here if I see any new occurrence

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Mentions crash #21030

If no regressions arise, payment will be issued on 2023-06-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@MonilBhavsar] Determine if we should create a regression test for this bug.
• [@MonilBhavsar] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kadiealexander]

Thanks for keeping this warm for me, April! Taking it back off you now :)

[kadiealexander]

@MonilBhavsar can this one be closed since it was all resolved internally?

[MonilBhavsar]

@0xmiroslav reviewed the PR. So I think we might need to pay them

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0106cd32b2d6c18034

[melvin-bot]

Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new.

[kadiealexander]

@0xmiroslav please let me know when you've accepted the offer!

[kadiealexander]

All paid! @MonilBhavsar is the checklist necessary here or can we close this out?

[MonilBhavsar]

Thanks! we can close this out as it was a kind of expected regression from personalDetails migration. We already have QA tests for mentions