Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in email font size when hovering over email and photo in group members section #20982

Closed
1 of 6 tasks
kavimuru opened this issue Jun 18, 2023 · 13 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Jun 18, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open the app and split a bill by selecting "Split Bill"
  2. Enter amount
  3. Select two random emails
  4. Select split
  5. Click on the report
  6. Hover over the email and then over the photo. When hovering over the email, the font size is displayed boldly, while when hovering over the photo, the font size is displayed lightly.

Expected Result:

When hovering over the email and photo, the email should have a consistent font size.

Actual Result:

When hovering over the email and photo, the tooltip shows different email font sizes.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.29-6
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687020595022329

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 18, 2023

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 18, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 18, 2023

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kevinksullivan
Copy link
Contributor

I am unable to reproduce this on v1.3.28-3

image image

Taking to slack to get clarity on whether this is still an issue.

@tewodrosGirmaA
Copy link

Hi @kevinksullivan , this issue happened on staging v1.3.29-2

@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

📣 @tewodrosGirmaA! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@srikarparsi
Copy link
Contributor

Hi @kavimuru, I am also unable to reproduce this issue on staging or dev. Will close it out but please reopen if necessary

Screen.Recording.2023-06-19.at.1.01.19.PM.mov
Screen.Recording.2023-06-19.at.1.00.16.PM.mov

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Jun 19, 2023
@kavimuru
Copy link
Author

@srikarparsi I am also not able to reproduce in the latest version.

@tewodrosGirmaA
Copy link

screen-capture (25).webm
Hey @srikarparsi, can you check this situation? Go to the plus sign > split bill > add desired number and click "next" > click on the profile to see the details > hover over the split bill members' email and photo to observe the difference. The email text is bold, while the photo text is lighter ....since the root couse is semilar , in above I reproduced in group memebers , now this happen on split bill memebers. Thank you

@tewodrosGirmaA
Copy link

hey @kevinksullivan @srikarparsi , I was able to reproduce the issue with group members in version V1.3.29-0, but it's not happening there anymore. However, the same issue is now happening with split bill members in V1.3.29-2. More details are provided in the video above. Thank you

@kevinksullivan
Copy link
Contributor

Discussed further in slack and it is a different issue specific to split bill, as @tewodrosGirmaA mentioned. Here's how they differ:

Staging

  • Hovering over avatar and email show unbold / bold text
screen-capture.25.webm

Production

  • Only hovering over avatar shows text
image

@srikarparsi
Copy link
Contributor

Will close it out as the split bill members page is consistent with the group members page (both the avatar and the name are bold on hover and can be clicked on to visit profile). @kevinksullivan please reopen though if you feel we should look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants