7.3 Deployment

[BHoMBot]

BHoM_Engine

Feature

• BHoM_Engine: null inputs enabled in TryRunExtensionMethod
• Ground_Engine: Add method that returns a unique list of suite names
  • Added DistinctSuites which gets all the unique suites for testing from the ContaminantSamples on a Borehole;
  • Updated IsValid method and outputs;
  • Updated methods that reference IsValid();
  • Added ContaminantProperty method to return an IContaminantProperty based on Type;
• Ground_Engine: Consolidate method for a Borehole
  • Added ConsolidateStrata method that uses a property to combine sequential Stratum. For example, combining Stratum with the same ObservedGeology property.
• Ground_Engine: Remove blankGeology from Stratum Create method
  • Removed blankGeology from the Create method for Stratum and versioned the method;
• Structure_Engine: Add engine methods for retaining wall classes
  • Added required extension methods for implemented interfaces for new retaining wall classes.
  • Added Geometry() method for Stem and RetainingWall
  • Added IsNull() method for Stem and RetainingWall
  • Added SolidVolume() method for Stem and RetainingWall
  • Added MaterialComposition() method for Stem and RetainingWall
  • Added SetOutlineElements(List<IElement1D> outlineElements1D) method for Stem
  • Added OutlineElemets1D() method for Stem
  • Added Geometry3D() method for Stem and RetainingWall
  • Migrated IsQuad, IsTriangular, IsRectangular, IsSquare to the Geometry namespace so that it can be used on PolyCurves the methods in BH.Engine.Analytical are unchanged, and just reference the Geometry methods.

Bug

• BHoM_Engine: Additional check for assembly qualified type without version for Create EngineType
• Geometry_Engine: BooleanDifference secured against single-dimensional regions
• Search_Engine: Update unit tests for ExtractAll, ExtractTop, ExtractSorted and MatchScore
  • Updated UnitTests for ExtractAll, ExtractTop, ExtractSorted and MatchScore to reflect the changes made in Search_oM.
• Serialiser_Engine: fix for MessageForDeleted to be picked up for properties of types that have multiple matching types
• Structure_Engine: Fixed bug where PanelToFEMesh returned an error
  • Fixed by bug whereby one Edge existed in the opposite direction to the Panel would caush an error for PanelToFEMesh;
  • Fixed bug whereby DiscontinuityPoints() did not work for PolyCurve;
  • Updated unit tests for DiscontinuityPoints() to include open PolyCurves;
  • Replaced unit tests for FEMeshToPanel and PanelToFEMesh as the data was empty.
• Structure_Engine: Update PileFoundation Geometry method
  • Updated PileFoundation Geometry method to use IRegion Geometry method for the PileCap.
• Type matching based on unqualified names enabled in Create.EngineType
• Verifiaction: Add reference to Diffing_Engine to properly access the IsEqual method

Compliance

• Ground_Engine, BHoM_Engine: Add UnitTests for ConsolidateStrata, remove UTs for GeometryHash
  • Added unit tests for ConsolidateStrata method;
  • Removed unit tests for GeometryHash as the method was completey reworked;.
• Serialiser_Engine: Update NullOrEmptyCheck to just check for Null
  • Updated NullOrEmptyCheck in Serialise method for IBHoMObjects to just check null for Name properties;
  • Updated unit tests for CellularSectionFromBase following changes to the Serialse method;
• Serialiser_Engine: Various changes to get unit-tests functional
  • Removed test in Serialiser_Engine that contained Hashset<int> in the CustomData causing it to fail.
  • Added ExplictType for Hashset<T> to avoid failing UnitTest;
  • Removed null inputs from URL unit test that was causing a null execption;
  • Updated URL, IsPrototype and DocumentationURL unittests;
  • Removed tests for AllTypesIObject() and Versinoing from Serialiser_Engine_Tests because the [Ignore] attribute is not working as inteded for CI;
  • Removed serialiser test for BitMap as test is not functioning as intended for CI.
• Structure_Engine: Update UT for CellularSection
  • Updated unit tests for CellularSectionFromBase;
• Update AssemblyFileVersion to 7.3

[bhombot-ci]

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

[bhombot-ci]

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

[IsakNaslundBh]

@BHoMBot check code-compliance

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance

[alelom]

Approving Diffing_Engine based on the Diffing Testing procedure.

[bhombot-ci]

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on File_Toolkit

[bhombot-ci]

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on SQL_Toolkit

[bhombot-ci]

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on LadybugTools_Toolkit

[bhombot-ci]

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoMAnalytics_Toolkit

[gideontamir16]

Reviewed for Facades_Engine. Script functions as expected per Facade Engine test procedure

[bhombot-ci]

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

[bhombot-ci]

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

[bhombot-ci]

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on Revit_Documentation_Tool

[JohnSloane]

Reviewed for Lighting_Engine. Script functions as expected per Lighting Engine test procedure.

[bhombot-ci]

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on Revit_SecurityICT_Tool

[bhombot-ci]

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on Revit_UI

[vgreen-BH]

Reviewed for Facades using the 9/17 beta artefact, all is behaving as expected per the test procedure.

[jamesramsden-bh]

Regarding Environment_Engine only: Tested as per test procedure, test results saved in 'Physics 7.3 testing plan'. No issues found in Environment_Engine that would block a merge.

[bhombot-ci]

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on ETABS_Toolkit

[bhombot-ci]

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on ETABS_Toolkit

[bhombot-ci]

@BHoMBot just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM