-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search_Engine: Update unit tests for ExtractAll, ExtractTop, ExtractSorted and MatchScore #3377
Search_Engine: Update unit tests for ExtractAll, ExtractTop, ExtractSorted and MatchScore #3377
Conversation
@BHoMBot check unit-tests |
@peterjamesnugent to confirm, the following actions are now queued:
There are 18 requests in the queue ahead of you. |
@peterjamesnugent just to let you know, I have provided a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense, happy to approve.
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
There are 31 requests in the queue ahead of you. |
@peterjamesnugent just to let you know, I have provided a |
The check |
The check |
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
2 similar comments
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
Dispensating unit test check on the basis of a fact that this PR lowers the number of failing UTs and does not introduce any new ones. |
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27369815469 |
@pawelbaran I have now provided a passing check on reference |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check dataset-compliance |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check dataset-compliance |
@pawelbaran to confirm, the following actions are now queued:
|
NOTE: Depends on
BHoM/BHoM#1628
Issues addressed by this PR
Closes #3376
Test files
#3376-SearchEngineUTFailure
Changelog
UnitTest
s forExtractAll
,ExtractTop
,ExtractSorted
andMatchScore
to reflect the changes made inSearch_oM
.Additional comments
One issue with unit tests was caused because it included a
CustomObject
that could not be serialised.