Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search_Engine: Update unit tests for ExtractAll, ExtractTop, ExtractSorted and MatchScore #3377

Merged

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Jul 12, 2024

NOTE: Depends on

BHoM/BHoM#1628

Issues addressed by this PR

Closes #3376

Test files

#3376-SearchEngineUTFailure

Changelog

  • Updated UnitTests for ExtractAll, ExtractTop, ExtractSorted and MatchScore to reflect the changes made in Search_oM.

Additional comments

One issue with unit tests was caused because it included a CustomObject that could not be serialised.

@peterjamesnugent peterjamesnugent added the type:bug Error or unexpected behaviour label Jul 12, 2024
@peterjamesnugent peterjamesnugent added this to the BHoM 7.3 β MVP milestone Jul 12, 2024
@peterjamesnugent peterjamesnugent self-assigned this Jul 12, 2024
@peterjamesnugent peterjamesnugent changed the title Update unit tests for ExtractAll, ExtractSorted, ExtractTop and Match… Search_Engine: Update unit tests for ExtractAll, ExtractTop, ExtractSorted and MatchScore Jul 12, 2024
@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jul 12, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests

There are 18 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jul 12, 2024

@peterjamesnugent just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, happy to approve.

@pawelbaran
Copy link
Member

@BHoMBot check required

Copy link

bhombot-ci bot commented Jul 12, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 31 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jul 12, 2024

@peterjamesnugent just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM

Copy link

bhombot-ci bot commented Jul 12, 2024

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jul 12, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jul 12, 2024

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27369815469

2 similar comments
Copy link

bhombot-ci bot commented Jul 12, 2024

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27369815469

Copy link

bhombot-ci bot commented Jul 15, 2024

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27369815469

@pawelbaran
Copy link
Member

pawelbaran commented Jul 15, 2024

Dispensating unit test check on the basis of a fact that this PR lowers the number of failing UTs and does not introduce any new ones.

@pawelbaran
Copy link
Member

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27369815469

Copy link

bhombot-ci bot commented Jul 15, 2024

@pawelbaran I have now provided a passing check on reference 27369815469 as requested.

@pawelbaran
Copy link
Member

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jul 15, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

@pawelbaran
Copy link
Member

@BHoMBot check dataset-compliance

Copy link

bhombot-ci bot commented Jul 15, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check dataset-compliance

@pawelbaran
Copy link
Member

@BHoMBot check dataset-compliance

Copy link

bhombot-ci bot commented Jul 15, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check dataset-compliance

@pawelbaran pawelbaran merged commit 04a19b8 into develop Jul 15, 2024
12 checks passed
@pawelbaran pawelbaran deleted the Search_oM-#1627-UpdateConstructorFromIntToDouble branch July 15, 2024 08:33
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search_Engine: Extract methods failing unit tests
2 participants