-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ground_Engine, BHoM_Engine: Add UnitTests for ConsolidateStrata, remove UTs for GeometryHash #3379
Ground_Engine, BHoM_Engine: Add UnitTests for ConsolidateStrata, remove UTs for GeometryHash #3379
Conversation
@BHoMBot check unit-tests |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@pawelbaran to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the basis of the following:
- tests for
ConsolidateStrata
are greenfield GeometryHash
method has been reworked and is well covered in https://github.com/BHoM/DiffingTests_Prototypes, as discussed with @alelom
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
|
Dispensating the |
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27950483319 |
@pawelbaran I have now provided a passing check on reference |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #3378
Closes #3382
Test files
https://burohappold.sharepoint.com/:u:/s/BHoM/EfuNrrGbo51BoKd5CUBw1agBW86KkaYx17ZTBNp2-V3Beg?e=rMcf8E
Changelog
ConsolidateStrata
method;GeometryHash
as the method was completey reworked;.Additional comments