Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ground_Engine, BHoM_Engine: Add UnitTests for ConsolidateStrata, remove UTs for GeometryHash #3379

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Jul 25, 2024

Issues addressed by this PR

Closes #3378
Closes #3382

Test files

https://burohappold.sharepoint.com/:u:/s/BHoM/EfuNrrGbo51BoKd5CUBw1agBW86KkaYx17ZTBNp2-V3Beg?e=rMcf8E

Changelog

  • Added unit tests for ConsolidateStrata method;
  • Removed unit tests for GeometryHash as the method was completey reworked;.

Additional comments

@peterjamesnugent peterjamesnugent added the type:compliance Non-conforming to code guidelines label Jul 25, 2024
@peterjamesnugent peterjamesnugent added this to the BHoM 7.3 β MVP milestone Jul 25, 2024
@peterjamesnugent peterjamesnugent self-assigned this Jul 25, 2024
@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jul 25, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests

@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jul 25, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests

@pawelbaran pawelbaran changed the title Ground_Engine: Add UnitTests for ConsolidateStrata Ground_Engine, BHoM_Engine: Add UnitTests for ConsolidateStrata, remove UTs for GeometryHash Jul 26, 2024
@pawelbaran
Copy link
Member

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jul 26, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of the following:

@pawelbaran
Copy link
Member

@BHoMBot check required

Copy link

bhombot-ci bot commented Jul 26, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@pawelbaran
Copy link
Member

Dispensating the unit-tests check based on the fact that the reported failure also occurs on develop.

Copy link

bhombot-ci bot commented Jul 26, 2024

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27950483319

@BHoM BHoM deleted a comment from bhombot-ci bot Jul 26, 2024
@pawelbaran
Copy link
Member

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27950483319

Copy link

bhombot-ci bot commented Jul 26, 2024

@pawelbaran I have now provided a passing check on reference 27950483319 as requested.

@pawelbaran
Copy link
Member

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Jul 26, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jul 26, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit f705a40 into develop Jul 26, 2024
12 checks passed
@pawelbaran pawelbaran deleted the Ground_Engine-#3378-AddUTsForConsolidateBorehole branch July 26, 2024 07:33
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BHoM_Engine: Remove defunct unit tests Ground_Engine: Unit tests for Consolidate Borehole
2 participants