-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure_Engine: Update UT for CellularSection #3381
Structure_Engine: Update UT for CellularSection #3381
Conversation
@BHoMBot check unit-tests |
@peterjamesnugent to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the basis of comparison of the .json files before and after: the only differences observed are BHoM_Guid
and presence of Name
property on one hand side, which is in line with @peterjamesnugent's PR description. So in essence, the datasets were updated without any change to the test itself.
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
Dispensating the |
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27915619358 |
@pawelbaran I have now provided a passing check on reference |
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
|
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #3380
Test files
Changelog
CellularSectionFromBase
;Additional comments
@pawelbaran this is because the commits we made to remove checking the
Name
property altogether in theSerialise
method - and I never updated the UTs.