Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure_Engine: Update UT for CellularSection #3381

Merged

Conversation

peterjamesnugent
Copy link
Member

Issues addressed by this PR

Closes #3380

Test files

Changelog

  • Updated unit tests for CellularSectionFromBase;

Additional comments

@pawelbaran this is because the commits we made to remove checking the Name property altogether in the Serialise method - and I never updated the UTs.

@peterjamesnugent peterjamesnugent added the type:compliance Non-conforming to code guidelines label Jul 25, 2024
@peterjamesnugent peterjamesnugent added this to the BHoM 7.3 β MVP milestone Jul 25, 2024
@peterjamesnugent peterjamesnugent self-assigned this Jul 25, 2024
@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jul 25, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of comparison of the .json files before and after: the only differences observed are BHoM_Guid and presence of Name property on one hand side, which is in line with @peterjamesnugent's PR description. So in essence, the datasets were updated without any change to the test itself.

Copy link

bhombot-ci bot commented Jul 26, 2024

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27915619358

@pawelbaran
Copy link
Member

Dispensating the unit-tests check based on the fact that the reported failure also occurs on develop.

@pawelbaran
Copy link
Member

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27915619358

Copy link

bhombot-ci bot commented Jul 26, 2024

@pawelbaran I have now provided a passing check on reference 27915619358 as requested.

@pawelbaran
Copy link
Member

@BHoMBot check required

Copy link

bhombot-ci bot commented Jul 26, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@pawelbaran
Copy link
Member

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Jul 26, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jul 26, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit f1e9138 into develop Jul 26, 2024
12 checks passed
@pawelbaran pawelbaran deleted the Structure_Engine-#3380-UpdateUTsForCellularSectionMethods branch July 26, 2024 07:40
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure_Engine: Update CellularSectionFromSection
2 participants