Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ground_Engine: Add method that returns a unique list of suite names #3396

Merged
merged 14 commits into from
Aug 29, 2024

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Aug 13, 2024

Issues addressed by this PR

Closes #3395

Test files

https://burohappold.sharepoint.com/:u:/s/BHoM/Ea1ITPbisJ9FluD0BrkYMJMBSVESWJtefVkIdnPr1VuJuQ?e=cdP7fG

Changelog

  • Added DistinctSuites which gets all the unique suites for testing from the ContaminantSamples on a Borehole;
  • Updated IsValid method and outputs;
  • Updated methods that reference IsValid();
  • Added ContaminantProperty method to return an IContaminantProperty based on Type;

Additional comments

@peterjamesnugent peterjamesnugent added the type:feature New capability or enhancement label Aug 13, 2024
@peterjamesnugent peterjamesnugent added this to the BHoM 7.3 β MVP milestone Aug 13, 2024
@peterjamesnugent peterjamesnugent self-assigned this Aug 13, 2024
@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Aug 13, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 87 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

peterjamesnugent commented Aug 15, 2024

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Aug 15, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Aug 15, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 12 requests in the queue ahead of you.

jtrainor1
jtrainor1 previously approved these changes Aug 28, 2024
Copy link

@jtrainor1 jtrainor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component works in organising contaminant samples by first sample reference, then depth and finally test name.

@peterjamesnugent peterjamesnugent force-pushed the Ground_Engine-#3395-ReturnUniqueSuites branch from ab8763f to c8ac095 Compare August 28, 2024 13:16
@peterjamesnugent
Copy link
Member Author

@BHoMBot check required
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Aug 28, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check copyright-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Aug 28, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 14 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Aug 28, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@jtrainor1 jtrainor1 self-requested a review August 28, 2024 14:31
Copy link

@jtrainor1 jtrainor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component works as intended. Organising contaminant data based on Specimen Reference, then depth and finally test name.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Aug 28, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests

There are 52 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Aug 29, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check dataset-compliance
  • check copyright-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Aug 29, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit b65d15a into develop Aug 29, 2024
12 checks passed
@IsakNaslundBh IsakNaslundBh deleted the Ground_Engine-#3395-ReturnUniqueSuites branch August 29, 2024 08:49
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
@jtrainor1 jtrainor1 restored the Ground_Engine-#3395-ReturnUniqueSuites branch October 8, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ground_Engine: Add method for counting the number of suites in the ContaminantSample
3 participants