-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ground_Engine: Add method that returns a unique list of suite names #3396
Ground_Engine: Add method that returns a unique list of suite names #3396
Conversation
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
There are 87 requests in the queue ahead of you. |
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Component works in organising contaminant samples by first sample reference, then depth and finally test name.
ab8763f
to
c8ac095
Compare
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
There are 14 requests in the queue ahead of you. |
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The component works as intended. Organising contaminant data based on Specimen Reference, then depth and finally test name.
@BHoMBot check unit-tests |
@peterjamesnugent to confirm, the following actions are now queued:
There are 52 requests in the queue ahead of you. |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@peterjamesnugent to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #3395
Test files
https://burohappold.sharepoint.com/:u:/s/BHoM/Ea1ITPbisJ9FluD0BrkYMJMBSVESWJtefVkIdnPr1VuJuQ?e=cdP7fG
Changelog
DistinctSuites
which gets all the unique suites for testing from theContaminantSamples
on aBorehole
;IsValid
method and outputs;IsValid()
;ContaminantProperty
method to return anIContaminantProperty
based onType
;Additional comments