Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type matching based on unqualified names enabled in Create.EngineType #3389

Merged
merged 7 commits into from
Aug 5, 2024

Conversation

pawelbaran
Copy link
Member

This is a reincarnation of #3387 required after renaming the branch

Issues addressed by this PR

Closes #3385
Closes #3386

Test files

Passing serialisation and versioning checks should be enough of verification.

Changelog

Additional comments

Fix for #3385 is almost self-explanatory, while #3386 requires a bit of explanation I believe. The origin of the bug is renaming of Revit assemblies that led me to finding out that Create.EngineType matches types based on fully qualified name - after renaming the assemblies the old and new names are different, resulting in a failure. Two steps were required to address that:

  1. Enabling matching by unqualified name
  2. Enabling picking first type in case of finding multiple matching types, similar to what we did with @IsakNaslundBh in BHoM_Engine: creation of type in case of multiple matching types fixed #3344

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Aug 5, 2024
@pawelbaran pawelbaran self-assigned this Aug 5, 2024
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after branch name change.

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Aug 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit f56fb5f into develop Aug 5, 2024
13 checks passed
@pawelbaran pawelbaran deleted the BHoM_Engine-#3386-CreateEngineTypeFix branch August 5, 2024 12:51
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
2 participants