Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoM_Engine: creation of type in case of multiple matching types fixed #3344

Merged
merged 2 commits into from
May 6, 2024

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Closes #3343

Test files

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label May 6, 2024
@pawelbaran pawelbaran requested a review from IsakNaslundBh May 6, 2024 12:58
@pawelbaran pawelbaran self-assigned this May 6, 2024
@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented May 6, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented May 6, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have talked through implications of this, adn tested on my machine. Happy to approve as long as bot checks pass

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check required
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented May 6, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check unit-tests

Copy link

bhombot-ci bot commented May 6, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented May 6, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented May 6, 2024

FAO: @FraserGreenroyd
@IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24633464288

@IsakNaslundBh
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24633464288

Copy link

bhombot-ci bot commented May 6, 2024

@IsakNaslundBh I have now provided a passing check on reference 24633464288 as requested.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented May 6, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit 35259da into develop May 6, 2024
13 checks passed
@IsakNaslundBh IsakNaslundBh deleted the BHoM_Engine-#3343-SerialisationEdgeCases branch May 6, 2024 14:01
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialiser_Engine: edge case issues with deserialising objects after versioning
2 participants