7.2 Deployment #3354
7.2 Deployment #3354
Conversation
![bhombot-ci[bot]](https://avatars.githubusercontent.com/in/74982?s=60&v=4){kind=small}
Many behind the upgrade from removing the Node name from start end performed in #3236 Simply re-serialising all of them to make sure they are up to date and do not need versioning to deserialise
Issue stemming from c65b01f where the call to extract the geometry from the FEMesh was removed, and the method instead was changed to simply call itself. Correcting namespace of Elements0D for the pile class as that was assigned wrong namespace, which in turn was making it impossible to reach the code for extracting the geometry for the FEMesh
downgrading again due to some serialisation issues
…sues. Difference showcased affects 12 significant figure, hence no real difference
UTs started failing after change of IsPlanar methodology in #3298 For this, the panels have been made planar by projected them to their plane. Panels failing where out of plane by ~2e-6, hence tests should still be valid.
Raised issue #3335 to fix
…rsion Potential scope to improve the behaviour compared to previous version, but for this first system change prefer to make the systems behave literally identical to ensure this switch gives as small impact in terms of functionality as possible.
… main process rather than via pipes (#3332)
…lso refactor to use the same methodology used by takeoff methods for aggregation. Solves #3335
…ssue, but rather the proble described in #3335
The unit tests that were failing due to the changes where: Mass: - Numerical tolerance issue where the mass for some panels where mass was differing on the 14th significant digit For the rest: -Fragments no longer present (which is the sole intention of this PR)
…erialComposition (#3337)
bhombot-ci
bot
requested review from
peterjamesnugent,
kayleighhoude,
travispotterBH,
tg359,
jamesramsden-bh and
alelom
as code owners
There was a problem hiding this comment.
Approved from a Structures perspective, BuiltUpDoubleRibbed tested, see @eden-reynell review for Geometry3D and tested the unit tests. Happy they pass apart from the Cellular which has been raised here:
#3357
|
@BHoMBot check compliance |
|
@michaelhoehn to confirm, the following actions are now queued:
There are 26 requests in the queue ahead of you. |
|
@michaelhoehn to confirm, the following actions are now queued:
There are 267 requests in the queue ahead of you. |
|
Reviewed for Facades using the 6/17 beta artefact, all is behaving as expected per the test procedure. |
|
Reviewed for Facades using 6/18 beta artefact. 3 issues encountered during testing procedure. Potential issues with SetOffestFromFaceToFaceDist Component and with UValueOpeningAW Component. Currently under review by facades team. |
|
@bhombot-ci[bot] just to let you know, I have provided a |
|
@BHoMBot check dataset-compliance |
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
|
@bhombot-ci[bot] just to let you know, I have provided a |
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core |
|
@IsakNaslundBh I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
|
@bhombot-ci[bot] just to let you know, I have provided a |
BHoM_Engine
Feature
Pile,PadFoundationandPileFoundation;Bug
Compliance
Test-script