-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facade_Engine: Geometry queries added for facade elements #3334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested with various facade geometry from revit pulls and natively created and this works as expected, representing correct geometry.
@BHoMBot check compliance |
@pawelbaran to confirm, the following actions are now queued:
There are 7 requests in the queue ahead of you. |
@BHoMBot check compliance |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
The check |
The check |
@pawelbaran just to let you know, I have provided a |
The check |
@pawelbaran just to let you know, I have provided a |
@pawelbaran just to let you know, I have provided a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only change since last review is copyright addition
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@pawelbaran to confirm, the following actions are now queued:
There are 7 requests in the queue ahead of you. |
bf0a75c
to
7300f58
Compare
@BHoMBot check unit-tests |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@pawelbaran to confirm, the following actions are now queued:
There are 66 requests in the queue ahead of you. |
@pawelbaran to confirm, the following actions are now queued:
There are 91 requests in the queue ahead of you. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24144886781 |
@IsakNaslundBh I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #3333
Test files
See #3333
Changelog
Additional comments