Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facade_Engine: Geometry queries added for facade elements #3334

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Apr 19, 2024

Issues addressed by this PR

Closes #3333

Test files

See #3333

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Apr 19, 2024
@pawelbaran pawelbaran self-assigned this Apr 19, 2024
enarhi
enarhi previously approved these changes Apr 19, 2024
Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with various facade geometry from revit pulls and natively created and this works as expected, representing correct geometry.

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Apr 22, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 7 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Apr 22, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Apr 22, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 8 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Apr 22, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Apr 22, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Apr 22, 2024

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

Copy link

bhombot-ci bot commented Apr 22, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Apr 22, 2024

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

Copy link

bhombot-ci bot commented Apr 22, 2024

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@enarhi enarhi self-requested a review April 22, 2024 15:55
Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only change since last review is copyright addition

@pawelbaran
Copy link
Member Author

@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Apr 22, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests
  • check ready-to-merge

@pawelbaran
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Apr 23, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

There are 7 requests in the queue ahead of you.

@pawelbaran pawelbaran force-pushed the Revit_Toolkit-#1459-FacadeConvertRevamp branch from bf0a75c to 7300f58 Compare April 23, 2024 09:41
@pawelbaran
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Apr 23, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Apr 23, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 66 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check serialisation
@BHoMBot check null-handling
@BHoMBot check versioning
@BHoMBot check installer

Copy link

bhombot-ci bot commented Apr 23, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check serialisation
  • check null-handling
  • check versioning
  • check installer

There are 91 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Apr 23, 2024

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24144886781

@IsakNaslundBh
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24144886781

Copy link

bhombot-ci bot commented Apr 23, 2024

@IsakNaslundBh I have now provided a passing check on reference 24144886781 as requested.

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Apr 23, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit 544238d into develop Apr 23, 2024
13 checks passed
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1459-FacadeConvertRevamp branch April 23, 2024 13:33
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facade_Engine: missing Geometry queries cause UI glitches
3 participants