-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure_Engine: Add method required for new BuiltUpDoubleRibbed surface property #3351
Structure_Engine: Add method required for new BuiltUpDoubleRibbed surface property #3351
Conversation
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 7 requests in the queue ahead of you. |
@BHoMBot check required |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 6 requests in the queue ahead of you. |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
Co-authored-by: Peter Nugent <[email protected]>
…ure messaging regarding reinforcement for case of only non concrete is shown
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the functionality, and the refactor of MaterialComposition
using a reinforcmentDensity is much clearer.
Just a few changes to descriptions and labels.
Co-authored-by: Peter Nugent <[email protected]>
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@BHoMBot check required |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 7 requests in the queue ahead of you. |
The check |
The check |
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy all my description/naming changes have been made, and based on previous review happy with the functionality presented in the test script.
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 27 requests in the queue ahead of you. |
@BHoMBot check installer |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
NOTE: Depends on
BHoM/BHoM#1615
Issues addressed by this PR
Add all required methods for the added BuiltUpDoubleRibbed surface property.
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM/Structure_oM/%231615-AddDoubleRibSurfaceProperty?csf=1&web=1&e=SjcnHu
Changelog
Additional comments