Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure_Engine: Add method required for new BuiltUpDoubleRibbed surface property #3351

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented May 28, 2024

NOTE: Depends on

BHoM/BHoM#1615

Issues addressed by this PR

Add all required methods for the added BuiltUpDoubleRibbed surface property.

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM/Structure_oM/%231615-AddDoubleRibSurfaceProperty?csf=1&web=1&e=SjcnHu

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label May 28, 2024
@IsakNaslundBh IsakNaslundBh self-assigned this May 28, 2024
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented May 28, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 7 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented May 28, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 6 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented May 28, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented May 28, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh IsakNaslundBh marked this pull request as ready for review May 28, 2024 09:19
@IsakNaslundBh IsakNaslundBh requested a review from rwemay as a code owner May 28, 2024 09:19
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

Structure_Engine/Query/MassPerArea.cs Show resolved Hide resolved
Structure_Engine/Query/TotalThickness.cs Outdated Show resolved Hide resolved
Structure_Engine/Query/VolumePerArea.cs Show resolved Hide resolved
Structure_Engine/Query/MaterialComposition.cs Outdated Show resolved Hide resolved
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented May 29, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the functionality, and the refactor of MaterialComposition using a reinforcmentDensity is much clearer.

Just a few changes to descriptions and labels.

Structure_Engine/Query/MaterialComposition.cs Outdated Show resolved Hide resolved
Structure_Engine/Query/MaterialComposition.cs Outdated Show resolved Hide resolved
Structure_Engine/Query/MaterialComposition.cs Outdated Show resolved Hide resolved
Structure_Engine/Query/TotalThickness.cs Outdated Show resolved Hide resolved
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented May 29, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented May 29, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 7 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented May 29, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented May 29, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

Copy link

bhombot-ci bot commented May 29, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented May 29, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented May 29, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy all my description/naming changes have been made, and based on previous review happy with the functionality presented in the test script.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented May 29, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

There are 27 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented May 29, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

Copy link

bhombot-ci bot commented May 29, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

Copy link

bhombot-ci bot commented May 29, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented May 29, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 12 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented May 29, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 875e9a8 into develop May 29, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Structure_oM-#1614-AddDoubleRibSurfaceProperty branch May 29, 2024 14:32
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants