Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning_Engine: Set Upgrader logging behaviour to false #3342

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

BHoM/Versioning_Toolkit#261

Issues addressed by this PR

Set the log to false for the Upgrader to avoid flood of upgrader messages.
See Versioning_Toolkit PR for more information.

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label May 3, 2024
@IsakNaslundBh IsakNaslundBh requested a review from pawelbaran May 3, 2024 11:39
@IsakNaslundBh IsakNaslundBh self-assigned this May 3, 2024
Copy link

bhombot-ci bot commented May 6, 2024

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Versioning_Toolkit

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve the changes following the review and discussion with @IsakNaslundBh 👍

Copy link

bhombot-ci bot commented May 6, 2024

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Versioning_Toolkit

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check serialisation
@BHoMBot check null-handling
@BHoMBot check core
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented May 6, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check serialisation
  • check null-handling
  • check core
  • check unit-tests

There are 14 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented May 6, 2024

FAO: @FraserGreenroyd
@IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24619975477

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24619975477

Copy link

bhombot-ci bot commented May 6, 2024

@IsakNaslundBh I have now provided a passing check on reference 24619975477 as requested.

@IsakNaslundBh
Copy link
Contributor Author

Dispensating UTs on the basis that they are not related to this PR

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented May 6, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit 07f4ac1 into develop May 6, 2024
13 checks passed
@IsakNaslundBh IsakNaslundBh deleted the Versioning_Toolkit-#260-TurnOfConsoleLoggingByDefault branch May 6, 2024 08:27
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants