Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialiser_Engine: Various changes to get unit-tests functional #3391

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Aug 6, 2024

Issues addressed by this PR

Closes #3390
Closes #3392

Test files

Check with CI/CD

Changelog

  • Removed test in Serialiser_Engine that contained Hashset<int> in the CustomData causing it to fail.
  • Added ExplictType for Hashset<T> to avoid failing UnitTest;
  • Removed null inputs from URL unit test that was causing a null execption;
  • Updated URL, IsPrototype and DocumentationURL unit-tests;
  • Removed tests for AllTypesIObject() and Versinoing from Serialiser_Engine_Tests because the [Ignore] attribute is not working as inteded for CI;
  • Removed serialiser test for BitMap as test is not functioning as intended for CI.

Additional comments

@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Aug 6, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests

@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Aug 6, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests

@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Aug 6, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests

@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Aug 8, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests

There are 23 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Aug 8, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests

There are 8 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Aug 8, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests

There are 4 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Aug 9, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests

@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Aug 15, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Aug 15, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Aug 15, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Aug 15, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Aug 15, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@alelom alelom self-requested a review August 15, 2024 13:48
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving following adjustment to my comment here:
#3391 (review)

@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests
@BHoMBot check dataset-compliance

Copy link

bhombot-ci bot commented Aug 15, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests
  • check dataset-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Aug 15, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

There are 20 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh added type:compliance Non-conforming to code guidelines type:test-script Creation of unit test required labels Aug 16, 2024
@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Aug 16, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit 7b7d245 into develop Aug 16, 2024
12 checks passed
@IsakNaslundBh IsakNaslundBh deleted the Seraliser_Engine-#3390-RemoveUnitTestWithHashsetInCustomData branch August 16, 2024 06:00
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines type:test-script Creation of unit test required
Projects
None yet
3 participants