-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialiser_Engine: Various changes to get unit-tests functional #3391
Serialiser_Engine: Various changes to get unit-tests functional #3391
Conversation
@BHoMBot check unit-tests |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@peterjamesnugent to confirm, the following actions are now queued:
There are 23 requests in the queue ahead of you. |
@BHoMBot check unit-tests |
@peterjamesnugent to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
@BHoMBot check unit-tests |
@peterjamesnugent to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
@BHoMBot check unit-tests |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check copyright-compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving following adjustment to my comment here:
#3391 (review)
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@peterjamesnugent to confirm, the following actions are now queued:
There are 20 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #3390
Closes #3392
Test files
Check with CI/CD
Changelog
Hashset<int>
in theCustomData
causing it to fail.ExplictType
forHashset<T>
to avoid failingUnitTest
;URL
unit test that was causing anull
execption;URL
,IsPrototype
andDocumentationURL
unit-tests;AllTypesIObject()
andVersinoing
from Serialiser_Engine_Tests because the[Ignore]
attribute is not working as inteded for CI;BitMap
as test is not functioning as intended for CI.Additional comments