Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: BooleanDifference secured against single-dimensional regions #3369

Merged

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Jul 4, 2024

Issues addressed by this PR

Closes #3368

Test files

On SharePoint.

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Jul 4, 2024
@pawelbaran pawelbaran self-assigned this Jul 4, 2024
@pawelbaran
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jul 4, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

@peterjamesnugent peterjamesnugent changed the title BooleanDifference secured against single-dimensional regions Geometry_Engine: BooleanDifference secured against single-dimensional regions Jul 5, 2024
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer causing the error reported in the issue. Unit tests are passing (based on script - bot is still running).

@pawelbaran
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jul 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

@pawelbaran
Copy link
Member Author

Using similar approach as in #3364, I can confirm that result of unit-tests check in this PR here are the same as in other branches (e.g. here), so by deduction, this PR does not introduce any UT failures.

@pawelbaran
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Jul 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Jul 5, 2024

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27077776498

@pawelbaran
Copy link
Member Author

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27077776498

Copy link

bhombot-ci bot commented Jul 5, 2024

@pawelbaran I have now provided a passing check on reference 27077776498 as requested.

@pawelbaran
Copy link
Member Author

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Jul 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jul 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit 85617f9 into develop Jul 5, 2024
12 checks passed
@pawelbaran pawelbaran deleted the BHoM_Engine-#3368-NullReferenceInBooleanOperations branch July 5, 2024 16:02
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry_Engine: BooleanDifference fails if one of the curves is singular
2 participants