Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure_Engine: Update PileFoundation Geometry method #3412

Conversation

peterjamesnugent
Copy link
Member

Issues addressed by this PR

Closes #3411

Test files

https://burohappold.sharepoint.com/:u:/s/BHoM/EYbRjWNJQ3xDnepsnRTz1cQBaOOADL2wUdPn9FdauQ_ZOw?e=MqaFkK

Changelog

  • Updated PileFoundation Geometry method to use IRegion Geometry method for the PileCap.

Additional comments

@peterjamesnugent peterjamesnugent added the type:bug Error or unexpected behaviour label Sep 4, 2024
@peterjamesnugent peterjamesnugent added this to the BHoM 7.3 β MVP milestone Sep 4, 2024
@peterjamesnugent peterjamesnugent self-assigned this Sep 4, 2024
@peterjamesnugent peterjamesnugent changed the title Structure_Engine Structure_Engine: Update PileFoundation Geometry method Sep 4, 2024
@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Sep 4, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Sep 5, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by code inspection and change makes sense. As bot is able to compile, I am happy for this to be merged.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Sep 5, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit de6a8b0 into develop Sep 5, 2024
12 checks passed
@IsakNaslundBh IsakNaslundBh deleted the Structure_Engine-#3411-PileFoundationNotDisplayingGeometryCorrectly branch September 5, 2024 09:13
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure_Engine: PadFoundation does not display Geometry when used in a PileFoundation
2 participants