Code

Merge 14.3 code freeze into master#11371

Code

Merged

jkmassel merged 203 commits intomasterwordpress-mobile/WordPress-Android:masterfrom merge/14.3-code-freeze-to-masterwordpress-mobile/WordPress-Android:merge/14.3-code-freeze-to-masterCopy head branch name to clipboardFeb 24, 2020

+4,828-1,737

Commits

Commits on Dec 24, 2019

• Squashed 'libs/utils/' changes from 4c6e8c9234..a15de7604a

  Show description for 90001f8
  jd-alexander

  committed
  90001f8

• resolved conflicts and merged utils subtree

  jd-alexander

  committed
  e25e5bf

• updated gradle wrapper of utils project.

  jd-alexander

  committed
  f2056b2

• Fixed latitude missing column issue on api 29

  jd-alexander

  committed
  fc92d97

Commits on Jan 7, 2020

• Fix signup bottom sheet navigation bar buttons not visible issue

  ashiagr

  committed
  93f7493

Commits on Jan 13, 2020

• Convert BottomSheetDialog to BottomSheetDialogFragment and update styles

  ashiagr

  committed
  98c445c

• Avoid using a parameter in Fragment's constructor

  Show description for 4fd8960
  ashiagr

  committed
  4fd8960

Commits on Jan 14, 2020

• Remove dialog.setOnDismissListener

  ashiagr

  committed
  d15dd92

• Eliminate setRetainInstance(true)

  ashiagr

  committed
  1d51b1f

• Eliminate logic to manually recreate the dialog(fragment)

  ashiagr

  committed
  8dcfbc7

• Extract parts of code from onCreateView to onViewCreated

  ashiagr

  committed
  e0e8327

• Remove empty line after brace

  ashiagr

  committed
  db32c52

Commits on Jan 21, 2020

• Show full width navigation bar and restrict max width for large screens

  Show description for 9816868
  ashiagr

  committed
  9816868

Commits on Jan 22, 2020

• Update libs/login/WordPressLoginFlow/src/main/java/org/wordpress/android/login/widgets/WPBottomSheetDialogFragment.java

  Show description for 07eb798
  

  ashiagr

  and

  theck13

  authored
  07eb798

• Add null check for design_bottom_sheet layout

  ashiagr

  committed
  042eb3b

• Merge branch 'issue/10908-navigation-bar-buttons-not-visible-with-signup-sheet' of https://github.com/wordpress-mobile/WordPress-Android into issue/10908-navigation-bar-buttons-not-visible-with-sig…

  Show description for 12a221c
  ashiagr

  committed
  12a221c

Commits on Jan 27, 2020

• Add max-width for bottom sheet in landscape mode

  ashiagr

  committed
  65318de

Commits on Jan 29, 2020

• Add max-width for bottom sheet in landscape mode for phones

  ashiagr

  committed
  0666345

• Merge branch 'develop' into issue/10908-navigation-bar-buttons-not-visible-with-signup-sheet

  Show description for 081ca1a
  ashiagr

  committed
  081ca1a

Commits on Jan 30, 2020

• Adding follow button to Reader's followed sites item

  renanferrari

  committed
  386a911

• Implementing follow button in Reader's followed sites item

  renanferrari

  committed
  a872e8b

Commits on Feb 1, 2020

• Replacing hardcoded dimensions with @Dimen resources

  renanferrari

  committed
  c15a0fe

• Adding Architecture Infrastructure feature flags

  renanferrari

  committed
  1d6381b

Commits on Feb 6, 2020

• Revert other files

  lukewalczak

  committed
  e2604e0

• Update ref

  lukewalczak

  committed
  87e5179

• Update ref to point to gutenberg-mobile master

  lukewalczak

  committed
  121bb8d

• Merge pull request #10902 from wordpress-mobile/feat/linear-gradient

  Show description for eb31c5f
  lukewalczak

  authored
  eb31c5f

• A rough introduction of AutoSavePostIfNotDraftUseCase

  oguzkocer

  committed
  be3ad8b

• Rough integration of AutoSavePostIfNotDraftUseCase

  oguzkocer

  committed
  32da8c4

• Refactor AutoSavePostIfNotDraftUseCase so it's reusable

  oguzkocer

  committed
  ab80870

• Update FluxC hash which contains some fixes to fetching post status

  oguzkocer

  committed
  4cf02b7

Commits on Feb 9, 2020

• Introduce new classes to manage the searching functionality

  

  Annmarie Ziegler

  committed
  a3c55d4

• Update AppComponent to inject PageParentSearchFragment

  

  Annmarie Ziegler

  committed
  57cfc44

• Update ViewModelModule to for PageParentSearchViewModel

  

  Annmarie Ziegler

  committed
  163de54

• Set up the search on the menu

  

  Annmarie Ziegler

  committed
  00f594b

• Switch in a new xml file for PageParentFragment so it can be adjusted to handle search

  

  Annmarie Ziegler

  committed
  b567f8f

• updated to include liveData searchPages

  

  Annmarie Ziegler

  committed
  5a483ff

• Tie the search all together in the PageParentFragment (initializing, menu hook ups)

  

  Annmarie Ziegler

  committed
  75c606f

• Added view model test for pageparentSearch

  

  Annmarie Ziegler

  committed
  fb3a414

• remove log line from hideSearchList fun

  

  Annmarie Ziegler

  committed
  049978c

• Make sure the search icon shows on back tap

  

  Annmarie Ziegler

  committed
  7af8211

Commits on Feb 10, 2020

• Fixed klint style errors

  

  Annmarie Ziegler

  committed
  33aff7c

• Field renaming and method access changing.

  develric

  committed
  7280544

• Storing in shared prefs if the tag is Following tag.

  develric

  committed
  74d8d33

• Changes to manage self-hosted sites scenario and adding logic in the view model to auto update posts when user changes.

  develric

  committed
  bca7d13

• Merge branch 'feature/master-search-in-set-parent-page' into issue/11119-search-in-set-parent-page

  Show description for 26a5c89
  

  Annmarie Ziegler

  committed
  26a5c89

• removed unused variables

  

  Annmarie Ziegler

  committed
  5f5832b

• Moved pageParentSearchViewModel to the correct package to align with other view models

  

  Annmarie Ziegler

  committed
  13a5268

• Throw IllegalArgumentException if autosave use case is already handling a post

  oguzkocer

  committed
  738e71e

• remove the search tap from the onOptionsItemSelected fun

  

  Annmarie Ziegler

  committed
  39aff7c

• guard null check with ?.let instead of separate statements

  

  Annmarie Ziegler

  committed
  8f30c21

• Refactor AutoSavePostIfNotDraftUseCase

  oguzkocer

  committed
  6767c91

• Handle errors in AutoSavePostIfNotDraftUseCase

  oguzkocer

  committed
  0b2a89e

• Maintain search text across configuration change

  

  Annmarie Ziegler

  committed
  39bd891

• Removes the conversion to lowercase and uses contains with ignoreCase = true for filtering on query text

  

  Annmarie Ziegler

  committed
  eb0a0af

Commits on Feb 11, 2020

• Adding support to follow/unfollow RSS feed from Followed Sites list item

  renanferrari

  committed
  d582396

• Fix bottom sheet not disappearing after rotation

  ashiagr

  committed
  f963bc2

• Merge branch 'develop' into issue/10908-navigation-bar-buttons-not-visible-with-signup-sheet

  ashiagr

  committed
  9fa9606

• Point to gb-mobile develop with v1.22 merged

  hypest

  committed
  3dc3f1b

• Merge branch 'develop' into gutenberg/after_1.22.0

  hypest

  committed
  455cc28

• Merge pull request #11275 from wordpress-mobile/merge/14.2-code-freeze-to-develop

  Show description for e4577b1
  oguzkocer

  authored
  e4577b1

• Temporarily disable login and signup connected tests

  oguzkocer

  committed
  7f797fb

• Merge pull request #11283 from wordpress-mobile/issue/temporarily-disable-login-and-signup-connected-tests

  Show description for a00a51a
  jkmassel

  authored
  a00a51a

• Merge remote-tracking branch 'origin/develop' into issue/autosave-or-update-draft

  oguzkocer

  committed
  a70f33e

• Handle all AutoSavePostIfNotDraftResult types

  oguzkocer

  committed
  d01c3f8

Commits on Feb 12, 2020

• Adding methods to save user account fields in shared prefs.

  develric

  committed
  345d20d

• Adding strings resources for self-hosted.

  develric

  committed
  61413c2

• Refactoring the CTA(s) in bottom sheet for self-hosted sites.

  develric

  committed
  1ed243c

• Merge pull request #11225 from wordpress-mobile/gutenberg/after_1.22.0

  Show description for 17d855f
  hypest

  authored
  17d855f

• Fixing unit tests and adding a few more.

  develric

  committed
  076f9c7

• getReaderTag return null if wasFollowing field not available yet.

  develric

  committed
  c397602

• Adding Unit Test for TagUpdateClientUtilsProviderTest.

  develric

  committed
  f168337

• Merge pull request #11051 from wordpress-mobile/issue/10908-navigation-bar-buttons-not-visible-with-signup-sheet

  Show description for 34bab43
  theck13

  authored
  34bab43

• Enforcing Feature Flag.

  develric

  committed
  ededbca

• Merge pull request #11219 from wordpress-mobile/issue/11167-reader-followed-sites-button

  Show description for e0a5dde
  develric

  authored
  e0a5dde

Commits on Feb 13, 2020

• Implementing historical suggestions on the Reader initial search screen

  renanferrari

  committed
  64cde7b

• Adding Architecture Infrastructure feature flags

  renanferrari

  committed
  8c8b828

• Changed strings as per copy review.

  develric

  committed
  f5632c1

• Fixing bottom sheet RTL support.

  develric

  committed
  3f8eade

• Update Sentry sdk to v2.0

  claucookie

  committed
  cf7d758

• Observe AutoSavePostIfNotDraftUseCase.onPostChanged on MAIN thread with priority 9

  oguzkocer

  committed
  bb985b1

• Don't show error notifications for post autosave fails

  oguzkocer

  committed
  63fd0fe

• Add documentation for auto-save use case

  oguzkocer

  committed
  1268a78

• adjusted save button and parent selected functionality

  

  Annmarie Ziegler

  committed
  e9b4991

• Sets up AutoSavePostIfNotDraftUseCaseTest and adds fetch post status error test

  oguzkocer

  committed
  174b742

• Adds unit test for PostAutoSaveFailed

  oguzkocer

  committed
  19fad9d

• Adds post is draft in remote unit test for AutoSavePostIfNotDraftUseCase

  oguzkocer

  committed
  a3d06fb

• Adds post auto-saved unit test for AutoSavePostIfNotDraftUseCase

  oguzkocer

  committed
  2c77170

• Adds unit test for calling autoSavePostOrUpdateDraft with a local draft

  oguzkocer

  committed
  26db1f9

Commits on Feb 14, 2020

• Add isFirstResource param to RequestListener methods

  Show description for 372dfe2
  ashiagr

  committed
  372dfe2

• Merge pull request #11308 from wordpress-mobile/issue/11304-allow-separate-handling-of-thumbnail-fullsized-url

  Show description for de9b364
  malinajirka

  authored
  de9b364

• Missing import removed by mistake

  claucookie

  committed
  6f2b138

• reverting idea-codingStyles-project.xml back to the commit right before mine

  

  Annmarie Ziegler

  committed
  d4000c0

• Merge pull request #11269 from zwarm/issue/11119-search-in-set-parent-page

  Show description for 401a294
  malinajirka

  authored
  401a294

• Update release notes

  malinajirka

  committed
  bc517cf

• Merge branch 'develop' into feature/master-search-in-set-parent-page

  malinajirka

  committed
  3c27c0b

• Extracting common interfaces shared by the suggestion adapters

  renanferrari

  committed
  2a78650

• Bump version number

  oguzkocer

  committed
  bc1961c

• Updating Reader settings screen title

  renanferrari

  committed
  d4e2931

• Merge remote-tracking branch 'origin/develop' into issue/merge-14.2-to-develop

  oguzkocer

  committed
  fd6db80

• Marking Sites and Tags as tracked items.

  develric

  committed
  296f1b3

• Adding isRunning function to ReaderTracker.

  develric

  committed
  4002dd9

• Adding dedicated tracker to trace time spent in content filtered with reader subfilter.

  develric

  committed
  2d9f0bc

• Moving tracking into the View Model and adding tracking for subfiltered content.

  develric

  committed
  a56fa42

• Fixing Lint.

  develric

  committed
  582085e

• Fixing Unit Testing.

  develric

  committed
  0e5a128

Commits on Feb 15, 2020

• Additional lint fixing.

  develric

  committed
  032b7ac

Commits on Feb 17, 2020

• Replace isFirstResource in RequestListener methods with model param

  Show description for 39a3da8
  ashiagr

  committed
  39a3da8

• Remove unused import

  ashiagr

  committed
  4cef887

• Add @nonnull annotation on the Drawable parameter in onResourceReady

  ashiagr

  committed
  bdb26b5

• Merge pull request #11329 from wordpress-mobile/issue/11304-replace-glide-isfirstresource-with-model-param

  Show description for 5b042eb
  ashiagr

  authored
  5b042eb

• Adding comment to better explain a piece of logic in AppPrefs.getReaderTag function.

  develric

  committed
  4dc164e

• Renaming containsFollowing into containsFollowingTag and moving it inside ReaderTagList.

  develric

  committed
  bb5c692

• Remove clearBreadcrumbs()

  claucookie

  committed
  ec96954

• Refactoring isCurrentTagTheFollowingTag and isFollowing.

  develric

  committed
  bb7b190

• Renaming _execEmptyViewAction to _bottomSheetEmptyViewAction

  develric

  committed
  bc5a92f

• Renaming BottomSheetEmptyUiState to SubfilterBottomSheetEmptyUiState.

  develric

  committed
  8502a91

• Merge pull request #11313 from wordpress-mobile/feature/master-search-in-set-parent-page

  Show description for e616de8
  jd-alexander

  authored
  e616de8

• Add missing multdex configuration for Sentry

  claucookie

  committed
  8de19ab

• Renaming ReaderUtils.getDbOrInMemoryDefaultTag to ReaderUtils.getDefaultTagFromDbOrCreateInMemory.

  develric

  committed
  6562ce8

• Fixing Unit Testing.

  develric

  committed
  b1d594c

• Merge pull request #11293 from wordpress-mobile/issue/11168-reader-search-view

  Show description for 0519fcd
  develric

  authored
  0519fcd

• Merge pull request #11301 from wordpress-mobile/issue/ia-reader-rtl-review

  Show description for 6889a34
  develric

  authored
  6889a34

• Update gutenberg ref in preparation for Gutenberg v1.23.0 release

  mchowning

  committed
  bb1f264

• Add Gutenberg v1.23.0 changes to release notes

  mchowning

  committed
  4dc1642

Commits on Feb 18, 2020

• Adding contentDescription and making the remove filter button wider.

  develric

  committed
  51da2d0

• Making talkback announce selected item in reader bottomsheet.

  develric

  committed
  547cd44

• Adding talkback management of the reader bottomsheet empty states.

  develric

  committed
  f857c59

• Remove duplicate release not for gallery image sizes

  Show description for 3eeb523
  mchowning

  committed
  3eeb523

• Merge pull request #11334 from wordpress-mobile/remove-gallery-size-release-note

  Show description for 7949f58
  mchowning

  authored
  7949f58

• Update submodule ref in preparation for Gutenberg 1.23 release

  mchowning

  committed
  35fc9a5

• Moving _subFilters and _currentSubfilter to the Main UI Thread. Also separating responsabilities: loadSubFilters only needs to load subfilters and onSubfilterClicked only needs to update the curren…

  Show description for d5c29f4
  develric

  committed
  d5c29f4

• Creating method isSameBlogAs to check if two blogs/feeds are the same even if not fully having all same fields.

  develric

  committed
  cbcc52a

• Fixing Unit Test.

  develric

  committed
  a29b98a

• Update gutenberg ref in preparation for Gutenberg v1.23.0

  mchowning

  committed
  1b1c50d

• Update release notes

  Show description for 12fbfd0
  mchowning

  committed
  12fbfd0

Commits on Feb 19, 2020

• Renaming isSameBlogAs to isSameBlogOrFeedAs.

  develric

  committed
  82b884e

• Merge pull request #11270 from wordpress-mobile/issue/ia-reader-selfhosted-improvements

  Show description for d65d8c4
  khaykov

  authored
  d65d8c4

• Merge pull request #11302 from claucookie/feature/10698_update_sentry_sdk

  Show description for cbf5d71
  jkmassel

  authored
  cbf5d71

• Correcting type and simplifying isRunning function.

  develric

  committed
  7369d1a

• Improving readability of checked conditions.

  develric

  committed
  56f01bc

• Renaming method from onSubfilterChanged to onSubfilterSelected.

  develric

  committed
  09f76fb

• Merge branch 'develop' into issue/ia-reader-add-dedicated-tracking

  Show description for 9bdfb35
  develric

  committed
  9bdfb35

• Fixing method that was changed.

  develric

  committed
  a2aea53

• Fixing Lint.

  develric

  committed
  9202fcd

• Renaming method from manageSubfilter to onSubfilterReselected.

  develric

  committed
  ac146f1

• Renaming string resources as per review feedback.

  develric

  committed
  5e9a55a

• Removing unneeded dimension resource.

  develric

  committed
  1e031da

• Removing unneeded focusable field.

  develric

  committed
  7b2adcb

• Adding content description to root bottom sheet layout.

  develric

  committed
  071354a

• Merge pull request #11251 from wordpress-mobile/issue/autosave-or-update-draft

  Show description for c16e03f
  oguzkocer

  authored
  c16e03f

• Change bottom sheet content description as per review feedback.

  develric

  committed
  5d5e20b

• Merge pull request #11333 from wordpress-mobile/issue/10962-ia-reader-accessibility

  Show description for dfcb1d8
  develric

  authored
  dfcb1d8

Commits on Feb 20, 2020

• Removing INFORMATION_ARCHITECTURE_AVAILABLE for IA reader feature.

  develric

  committed
  b3b99ee

• Revert "Merge pull request #11302 from claucookie/feature/10698_update_sentry_sdk"

  Show description for bfbb6f7
  jkmassel

  committed
  bfbb6f7

• Merge pull request #11345 from wordpress-mobile/fix/connected-tests-on-develop

  Show description for e0c387c
  oguzkocer

  authored
  e0c387c

• Merge branch 'develop' into issue/ia-reader-add-dedicated-tracking

  develric

  committed
  933ea40

• Merge pull request #11325 from wordpress-mobile/issue/ia-reader-add-dedicated-tracking

  Show description for dce8e7d
  develric

  authored
  dce8e7d

• Merge branch 'develop' into issue/ia-reader-feature-flag-removal

  develric

  committed
  cddef32

• Removing imported feature flag after auto merge from develop and fixing lint.

  develric

  committed
  b97243d

• Fixing checkstyle.

  develric

  committed
  6680fe7

• Fixing visual bug with empty view cta for self-hosted.

  develric

  committed
  78c4b67

• Updating release notes.

  develric

  committed
  9783144

• Use submodule ref for Gutenberg v.1.22.1 instead of v1.22.0

  mchowning

  committed
  3bae610

• Update Gutenberg ref in preparation for Gutenberg 1.23.0 release

  mchowning

  committed
  a741a27

• Centering vertically the items of reader bottom sheet.

  develric

  committed
  aa58f29

• Adding id to coordinator layout so to preserve toolbar collapsing status.

  develric

  committed
  f094fa4

• Merge pull request #11323 from wordpress-mobile/issue/merge-14.2-to-develop

  Show description for 9818a02
  oguzkocer

  authored
  9818a02

• Ensuring the fragment isAdded before to continue with the AsyncTask.

  develric

  committed
  d4f9899

Commits on Feb 21, 2020

• Removing unused dimens resources.

  develric

  committed
  e3ba8b0

• Merge pull request #11356 from wordpress-mobile/issue/11343-pr-issue-4

  Show description for 13f3bf2
  malinajirka

  authored
  13f3bf2

• Merge pull request #11360 from wordpress-mobile/issue/11343-pr-avoid-issue-when-fragment-not-attached

  Show description for a8f972e
  malinajirka

  authored
  a8f972e

• Merge pull request #11343 from wordpress-mobile/issue/ia-reader-feature-flag-removal

  Show description for ec04292
  develric

  authored
  ec04292

• Update bottom sheet style to include rounded corners

  renanferrari

  committed
  49c6d5c

• Separate My Site bottom sheet layout from Subfilter page fragment layout

  renanferrari

  committed
  ea7b998

• Replicate style from Reader bottom sheet to My Site bottom sheet

  renanferrari

  committed
  bed19a3

• Rename bottom sheet handle layout file

  renanferrari

  committed
  31aac92

• Rename bottom sheet handle dimension resource

  renanferrari

  committed
  b8803f8

• Simplify the application of styles on the bottom sheet

  renanferrari

  committed
  d5f8e13

• Fix bottom sheet handle spacing

  renanferrari

  committed
  ea87f27

• Rename some bottom sheet dimension resources for consistency

  renanferrari

  committed
  4a60a07

• Extract a style for the main bottom sheet

  renanferrari

  committed
  3f59b7a

• Merge pull request #11337 from wordpress-mobile/issue/11326-update-my-site-bottom-sheet

  Show description for 9a357ea
  develric

  authored
  9a357ea

• Merge branch 'develop' into issue/11343-pr-issue-3

  develric

  committed
  3edc97b

• Update release notes

  mchowning

  committed
  db1c8e8

• Update gutenberg submodule ref

  mchowning

  committed
  debd401

• Reverting changes.

  develric

  committed
  31ade67

• Centering list items vertically in bottom sheet and removing margin top for recycler view.

  develric

  committed
  7b35d44

• Update gutenberg ref to Gutenberg v1.23.0 release tag

  mchowning

  committed
  63c7640

• Merge remote-tracking branch 'origin/develop' into gutenberg/integrate_release_1.23.0

  mchowning

  committed
  371e021

• Changing margin to padding.

  develric

  committed
  6347458

• Merge pull request #11355 from wordpress-mobile/issue/11343-pr-issue-3

  Show description for 2c4618c
  renanferrari

  authored
  2c4618c

• Merge pull request #11331 from wordpress-mobile/gutenberg/integrate_release_1.23.0

  Show description for 690f9d6
  mchowning

  authored
  690f9d6

Commits on Feb 22, 2020

• Merge pull request #11072 from wordpress-mobile/issue-10843/latitude_fix_api_29

  Show description for 0c64406
  khaykov

  authored
  0c64406

Commits on Feb 24, 2020

• Added the missing release note for the Block editor

  pinarol

  committed
  256f1e0

• Merge pull request #11368 from wordpress-mobile/fix/gutenberg-release-note

  Show description for e64f8a0
  pinarol

  authored
  e64f8a0

• Updates translations

  oguzkocer

  committed
  e92d69f

• Bump version number

  oguzkocer

  committed
  8ef9b90

• Update metadata translations for 14.2

  oguzkocer

  committed
  16c3cd8

• Merge pull request #11369 from wordpress-mobile/merge/14.2-into-develop

  Show description for e61bb90
  jkmassel

  authored
  e61bb90

• Bump version number

  oguzkocer

  committed
  c250af7

• Update release notes.

  oguzkocer

  committed
  400c1ea

• Update FluxC version to 1.6.4

  oguzkocer

  committed
  2234f67