Ensuring the fragment isAdded before to continue with the AsyncTask. #11360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to some consideration made during #11343 review (see here for more context)
With the following call path in
ReaderPostListFragment
:it can happen that the onRecallSelection (who calls requireActivity) could be called when the fragment is not added so resulting in a crash. This PR tries to mitigate that possibility checking that the fragment is attached to activity in
onPostExecute
To test
Was not able to trigger the issue so not fully sure how to test. At least smoke test the reader to check that we did not introduce issues.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.