Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve toolbar collapsing state in reader. #11356

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Preserve toolbar collapsing state in reader. #11356

merged 1 commit into from
Feb 21, 2020

Conversation

develric
Copy link
Contributor

This PR is related to issue 4 found during #11343 review (see here for more context)

To test

  • Go to reader
  • Collapse the toolbar
  • Rotate the device
  • Check the toolbar collapsing state is preserved

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@develric develric added this to the 14.3 milestone Feb 21, 2020
@develric develric requested a review from malinajirka February 21, 2020 00:36
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@develric develric mentioned this pull request Feb 21, 2020
Merged
3 tasks
@malinajirka malinajirka self-assigned this Feb 21, 2020
malinajirka
malinajirka approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@malinajirka malinajirka merged commit 13f3bf2 into issue/ia-reader-feature-flag-removal Feb 21, 2020
@malinajirka malinajirka deleted the issue/11343-pr-issue-4 branch February 21, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malinajirka malinajirka malinajirka approved these changes

@ashiagr ashiagr Awaiting requested review from ashiagr

@renanferrari renanferrari Awaiting requested review from renanferrari

Assignees

@malinajirka malinajirka

Labels
Reader [Type] Enhancement
Projects
None yet
Milestone
14.3
Development

Successfully merging this pull request may close these issues.
2 participants
@develric @malinajirka