Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 14.3 code freeze into master #11371

Merged
merged 203 commits into from
Feb 24, 2020
Merged
Changes from 1 commit
Commits
Show all changes
203 commits
Select commit Hold shift + click to select a range
90001f8
Squashed 'libs/utils/' changes from 4c6e8c9234..a15de7604a
jd-alexander Dec 24, 2019
e25e5bf
resolved conflicts and merged utils subtree
jd-alexander Dec 24, 2019
f2056b2
updated gradle wrapper of utils project.
jd-alexander Dec 24, 2019
fc92d97
Fixed latitude missing column issue on api 29
jd-alexander Dec 24, 2019
93f7493
Fix signup bottom sheet navigation bar buttons not visible issue
ashiagr Jan 7, 2020
98c445c
Convert BottomSheetDialog to BottomSheetDialogFragment and update styles
ashiagr Jan 13, 2020
4fd8960
Avoid using a parameter in Fragment's constructor
ashiagr Jan 13, 2020
d15dd92
Remove dialog.setOnDismissListener
ashiagr Jan 14, 2020
1d51b1f
Eliminate setRetainInstance(true)
ashiagr Jan 14, 2020
8dcfbc7
Eliminate logic to manually recreate the dialog(fragment)
ashiagr Jan 14, 2020
e0e8327
Extract parts of code from onCreateView to onViewCreated
ashiagr Jan 14, 2020
db32c52
Remove empty line after brace
ashiagr Jan 14, 2020
9816868
Show full width navigation bar and restrict max width for large screens
ashiagr Jan 21, 2020
07eb798
Update libs/login/WordPressLoginFlow/src/main/java/org/wordpress/andr…
ashiagr Jan 22, 2020
042eb3b
Add null check for design_bottom_sheet layout
ashiagr Jan 22, 2020
12a221c
Merge branch 'issue/10908-navigation-bar-buttons-not-visible-with-sig…
ashiagr Jan 22, 2020
65318de
Add max-width for bottom sheet in landscape mode
ashiagr Jan 27, 2020
0666345
Add max-width for bottom sheet in landscape mode for phones
ashiagr Jan 29, 2020
081ca1a
Merge branch 'develop' into issue/10908-navigation-bar-buttons-not-vi…
ashiagr Jan 29, 2020
386a911
Adding follow button to Reader's followed sites item
renanferrari Jan 30, 2020
a872e8b
Implementing follow button in Reader's followed sites item
renanferrari Jan 30, 2020
c15a0fe
Replacing hardcoded dimensions with @dimen resources
renanferrari Feb 1, 2020
1d6381b
Adding Architecture Infrastructure feature flags
renanferrari Feb 1, 2020
e2604e0
Revert other files
lukewalczak Feb 6, 2020
87e5179
Update ref
lukewalczak Feb 6, 2020
121bb8d
Update ref to point to gutenberg-mobile master
lukewalczak Feb 6, 2020
eb31c5f
Merge pull request #10902 from wordpress-mobile/feat/linear-gradient
lukewalczak Feb 6, 2020
be3ad8b
A rough introduction of AutoSavePostIfNotDraftUseCase
oguzkocer Feb 6, 2020
32da8c4
Rough integration of AutoSavePostIfNotDraftUseCase
oguzkocer Feb 6, 2020
ab80870
Refactor AutoSavePostIfNotDraftUseCase so it's reusable
oguzkocer Feb 6, 2020
4cf02b7
Update FluxC hash which contains some fixes to fetching post status
oguzkocer Feb 6, 2020
a3c55d4
Introduce new classes to manage the searching functionality
Feb 9, 2020
57cfc44
Update AppComponent to inject PageParentSearchFragment
Feb 9, 2020
163de54
Update ViewModelModule to for PageParentSearchViewModel
Feb 9, 2020
00f594b
Set up the search on the menu
Feb 9, 2020
b567f8f
Switch in a new xml file for PageParentFragment so it can be adjusted…
Feb 9, 2020
5a483ff
updated to include liveData searchPages
Feb 9, 2020
75c606f
Tie the search all together in the PageParentFragment (initializing, …
Feb 9, 2020
fb3a414
Added view model test for pageparentSearch
Feb 9, 2020
049978c
remove log line from hideSearchList fun
Feb 9, 2020
7af8211
Make sure the search icon shows on back tap
Feb 9, 2020
33aff7c
Fixed klint style errors
Feb 10, 2020
7280544
Field renaming and method access changing.
develric Feb 10, 2020
74d8d33
Storing in shared prefs if the tag is Following tag.
develric Feb 10, 2020
bca7d13
Changes to manage self-hosted sites scenario and adding logic in the …
develric Feb 10, 2020
26a5c89
Merge branch 'feature/master-search-in-set-parent-page' into issue/11…
Feb 10, 2020
5f5832b
removed unused variables
Feb 10, 2020
13a5268
Moved pageParentSearchViewModel to the correct package to align with …
Feb 10, 2020
738e71e
Throw IllegalArgumentException if autosave use case is already handli…
oguzkocer Feb 10, 2020
39aff7c
remove the search tap from the onOptionsItemSelected fun
Feb 10, 2020
8f30c21
guard null check with ?.let instead of separate statements
Feb 10, 2020
6767c91
Refactor AutoSavePostIfNotDraftUseCase
oguzkocer Feb 10, 2020
0b2a89e
Handle errors in AutoSavePostIfNotDraftUseCase
oguzkocer Feb 10, 2020
39bd891
Maintain search text across configuration change
Feb 10, 2020
eb0a0af
Removes the conversion to lowercase and uses contains with ignoreCase…
Feb 10, 2020
d582396
Adding support to follow/unfollow RSS feed from Followed Sites list item
renanferrari Feb 11, 2020
f963bc2
Fix bottom sheet not disappearing after rotation
ashiagr Feb 11, 2020
9fa9606
Merge branch 'develop' into issue/10908-navigation-bar-buttons-not-vi…
ashiagr Feb 11, 2020
3dc3f1b
Point to gb-mobile develop with v1.22 merged
hypest Feb 11, 2020
455cc28
Merge branch 'develop' into gutenberg/after_1.22.0
hypest Feb 11, 2020
e4577b1
Merge pull request #11275 from wordpress-mobile/merge/14.2-code-freez…
oguzkocer Feb 11, 2020
7f797fb
Temporarily disable login and signup connected tests
oguzkocer Feb 11, 2020
a00a51a
Merge pull request #11283 from wordpress-mobile/issue/temporarily-dis…
jkmassel Feb 11, 2020
a70f33e
Merge remote-tracking branch 'origin/develop' into issue/autosave-or-…
oguzkocer Feb 11, 2020
d01c3f8
Handle all AutoSavePostIfNotDraftResult types
oguzkocer Feb 11, 2020
345d20d
Adding methods to save user account fields in shared prefs.
develric Feb 12, 2020
61413c2
Adding strings resources for self-hosted.
develric Feb 12, 2020
1ed243c
Refactoring the CTA(s) in bottom sheet for self-hosted sites.
develric Feb 12, 2020
17d855f
Merge pull request #11225 from wordpress-mobile/gutenberg/after_1.22.0
hypest Feb 12, 2020
076f9c7
Fixing unit tests and adding a few more.
develric Feb 12, 2020
c397602
getReaderTag return null if wasFollowing field not available yet.
develric Feb 12, 2020
f168337
Adding Unit Test for TagUpdateClientUtilsProviderTest.
develric Feb 12, 2020
34bab43
Merge pull request #11051 from wordpress-mobile/issue/10908-navigatio…
theck13 Feb 12, 2020
ededbca
Enforcing Feature Flag.
develric Feb 12, 2020
e0a5dde
Merge pull request #11219 from wordpress-mobile/issue/11167-reader-fo…
develric Feb 12, 2020
64cde7b
Implementing historical suggestions on the Reader initial search screen
renanferrari Feb 13, 2020
8c8b828
Adding Architecture Infrastructure feature flags
renanferrari Feb 13, 2020
f5632c1
Changed strings as per copy review.
develric Feb 13, 2020
3f8eade
Fixing bottom sheet RTL support.
develric Feb 13, 2020
cf7d758
Update Sentry sdk to v2.0
claucookie Feb 13, 2020
bb985b1
Observe AutoSavePostIfNotDraftUseCase.onPostChanged on MAIN thread wi…
oguzkocer Feb 13, 2020
63fd0fe
Don't show error notifications for post autosave fails
oguzkocer Feb 13, 2020
1268a78
Add documentation for auto-save use case
oguzkocer Feb 13, 2020
e9b4991
adjusted save button and parent selected functionality
Feb 13, 2020
174b742
Sets up AutoSavePostIfNotDraftUseCaseTest and adds fetch post status …
oguzkocer Feb 13, 2020
19fad9d
Adds unit test for PostAutoSaveFailed
oguzkocer Feb 13, 2020
a3d06fb
Adds post is draft in remote unit test for AutoSavePostIfNotDraftUseCase
oguzkocer Feb 13, 2020
2c77170
Adds post auto-saved unit test for AutoSavePostIfNotDraftUseCase
oguzkocer Feb 13, 2020
26db1f9
Adds unit test for calling autoSavePostOrUpdateDraft with a local draft
oguzkocer Feb 13, 2020
372dfe2
Add isFirstResource param to RequestListener methods
ashiagr Feb 14, 2020
de9b364
Merge pull request #11308 from wordpress-mobile/issue/11304-allow-sep…
malinajirka Feb 14, 2020
6f2b138
Missing import removed by mistake
claucookie Feb 14, 2020
d4000c0
reverting idea-codingStyles-project.xml back to the commit right befo…
Feb 14, 2020
401a294
Merge pull request #11269 from zwarm/issue/11119-search-in-set-parent…
malinajirka Feb 14, 2020
bc517cf
Update release notes
malinajirka Feb 14, 2020
3c27c0b
Merge branch 'develop' into feature/master-search-in-set-parent-page
malinajirka Feb 14, 2020
2a78650
Extracting common interfaces shared by the suggestion adapters
renanferrari Feb 14, 2020
bc1961c
Bump version number
oguzkocer Feb 14, 2020
d4e2931
Updating Reader settings screen title
renanferrari Feb 14, 2020
fd6db80
Merge remote-tracking branch 'origin/develop' into issue/merge-14.2-t…
oguzkocer Feb 14, 2020
296f1b3
Marking Sites and Tags as tracked items.
develric Feb 14, 2020
4002dd9
Adding isRunning function to ReaderTracker.
develric Feb 14, 2020
2d9f0bc
Adding dedicated tracker to trace time spent in content filtered with…
develric Feb 14, 2020
a56fa42
Moving tracking into the View Model and adding tracking for subfilter…
develric Feb 14, 2020
582085e
Fixing Lint.
develric Feb 14, 2020
0e5a128
Fixing Unit Testing.
develric Feb 14, 2020
032b7ac
Additional lint fixing.
develric Feb 15, 2020
39a3da8
Replace isFirstResource in RequestListener methods with model param
ashiagr Feb 17, 2020
4cef887
Remove unused import
ashiagr Feb 17, 2020
bdb26b5
Add @NonNull annotation on the Drawable parameter in onResourceReady
ashiagr Feb 17, 2020
5b042eb
Merge pull request #11329 from wordpress-mobile/issue/11304-replace-g…
ashiagr Feb 17, 2020
4dc164e
Adding comment to better explain a piece of logic in AppPrefs.getRead…
develric Feb 17, 2020
bb5c692
Renaming containsFollowing into containsFollowingTag and moving it in…
develric Feb 17, 2020
ec96954
Remove clearBreadcrumbs()
claucookie Feb 17, 2020
bb7b190
Refactoring isCurrentTagTheFollowingTag and isFollowing.
develric Feb 17, 2020
bc5a92f
Renaming _execEmptyViewAction to _bottomSheetEmptyViewAction
develric Feb 17, 2020
8502a91
Renaming BottomSheetEmptyUiState to SubfilterBottomSheetEmptyUiState.
develric Feb 17, 2020
e616de8
Merge pull request #11313 from wordpress-mobile/feature/master-search…
jd-alexander Feb 17, 2020
8de19ab
Add missing multdex configuration for Sentry
claucookie Feb 17, 2020
6562ce8
Renaming ReaderUtils.getDbOrInMemoryDefaultTag to ReaderUtils.getDefa…
develric Feb 17, 2020
b1d594c
Fixing Unit Testing.
develric Feb 17, 2020
0519fcd
Merge pull request #11293 from wordpress-mobile/issue/11168-reader-se…
develric Feb 17, 2020
6889a34
Merge pull request #11301 from wordpress-mobile/issue/ia-reader-rtl-r…
develric Feb 17, 2020
bb1f264
Update gutenberg ref in preparation for Gutenberg v1.23.0 release
mchowning Feb 17, 2020
4dc1642
Add Gutenberg v1.23.0 changes to release notes
mchowning Feb 17, 2020
51da2d0
Adding contentDescription and making the remove filter button wider.
develric Feb 18, 2020
547cd44
Making talkback announce selected item in reader bottomsheet.
develric Feb 18, 2020
f857c59
Adding talkback management of the reader bottomsheet empty states.
develric Feb 18, 2020
3eeb523
Remove duplicate release not for gallery image sizes
mchowning Feb 18, 2020
7949f58
Merge pull request #11334 from wordpress-mobile/remove-gallery-size-r…
mchowning Feb 18, 2020
35fc9a5
Update submodule ref in preparation for Gutenberg 1.23 release
mchowning Feb 18, 2020
d5c29f4
Moving _subFilters and _currentSubfilter to the Main UI Thread. Also …
develric Feb 18, 2020
cbcc52a
Creating method isSameBlogAs to check if two blogs/feeds are the same…
develric Feb 18, 2020
a29b98a
Fixing Unit Test.
develric Feb 18, 2020
1b1c50d
Update gutenberg ref in preparation for Gutenberg v1.23.0
mchowning Feb 18, 2020
12fbfd0
Update release notes
mchowning Feb 18, 2020
82b884e
Renaming isSameBlogAs to isSameBlogOrFeedAs.
develric Feb 19, 2020
d65d8c4
Merge pull request #11270 from wordpress-mobile/issue/ia-reader-selfh…
khaykov Feb 19, 2020
cbf5d71
Merge pull request #11302 from claucookie/feature/10698_update_sentry…
jkmassel Feb 19, 2020
7369d1a
Correcting type and simplifying isRunning function.
develric Feb 19, 2020
56f01bc
Improving readability of checked conditions.
develric Feb 19, 2020
09f76fb
Renaming method from onSubfilterChanged to onSubfilterSelected.
develric Feb 19, 2020
9bdfb35
Merge branch 'develop' into issue/ia-reader-add-dedicated-tracking
develric Feb 19, 2020
a2aea53
Fixing method that was changed.
develric Feb 19, 2020
9202fcd
Fixing Lint.
develric Feb 19, 2020
ac146f1
Renaming method from manageSubfilter to onSubfilterReselected.
develric Feb 19, 2020
5e9a55a
Renaming string resources as per review feedback.
develric Feb 19, 2020
1e031da
Removing unneeded dimension resource.
develric Feb 19, 2020
7b2adcb
Removing unneeded focusable field.
develric Feb 19, 2020
071354a
Adding content description to root bottom sheet layout.
develric Feb 19, 2020
c16e03f
Merge pull request #11251 from wordpress-mobile/issue/autosave-or-upd…
oguzkocer Feb 19, 2020
5d5e20b
Change bottom sheet content description as per review feedback.
develric Feb 19, 2020
dfcb1d8
Merge pull request #11333 from wordpress-mobile/issue/10962-ia-reader…
develric Feb 19, 2020
b3b99ee
Removing INFORMATION_ARCHITECTURE_AVAILABLE for IA reader feature.
develric Feb 20, 2020
bfbb6f7
Revert "Merge pull request #11302 from claucookie/feature/10698_updat…
jkmassel Feb 20, 2020
e0c387c
Merge pull request #11345 from wordpress-mobile/fix/connected-tests-o…
oguzkocer Feb 20, 2020
933ea40
Merge branch 'develop' into issue/ia-reader-add-dedicated-tracking
develric Feb 20, 2020
dce8e7d
Merge pull request #11325 from wordpress-mobile/issue/ia-reader-add-d…
develric Feb 20, 2020
cddef32
Merge branch 'develop' into issue/ia-reader-feature-flag-removal
develric Feb 20, 2020
b97243d
Removing imported feature flag after auto merge from develop and fixi…
develric Feb 20, 2020
6680fe7
Fixing checkstyle.
develric Feb 20, 2020
78c4b67
Fixing visual bug with empty view cta for self-hosted.
develric Feb 20, 2020
9783144
Updating release notes.
develric Feb 20, 2020
3bae610
Use submodule ref for Gutenberg v.1.22.1 instead of v1.22.0
mchowning Feb 20, 2020
a741a27
Update Gutenberg ref in preparation for Gutenberg 1.23.0 release
mchowning Feb 20, 2020
aa58f29
Centering vertically the items of reader bottom sheet.
develric Feb 20, 2020
f094fa4
Adding id to coordinator layout so to preserve toolbar collapsing sta…
develric Feb 20, 2020
9818a02
Merge pull request #11323 from wordpress-mobile/issue/merge-14.2-to-d…
oguzkocer Feb 20, 2020
d4f9899
Ensuring the fragment isAdded before to continue with the AsyncTask.
develric Feb 20, 2020
e3ba8b0
Removing unused dimens resources.
develric Feb 21, 2020
13f3bf2
Merge pull request #11356 from wordpress-mobile/issue/11343-pr-issue-4
malinajirka Feb 21, 2020
a8f972e
Merge pull request #11360 from wordpress-mobile/issue/11343-pr-avoid-…
malinajirka Feb 21, 2020
ec04292
Merge pull request #11343 from wordpress-mobile/issue/ia-reader-featu…
develric Feb 21, 2020
49c6d5c
Update bottom sheet style to include rounded corners
renanferrari Feb 17, 2020
ea7b998
Separate My Site bottom sheet layout from Subfilter page fragment layout
renanferrari Feb 17, 2020
bed19a3
Replicate style from Reader bottom sheet to My Site bottom sheet
renanferrari Feb 17, 2020
31aac92
Rename bottom sheet handle layout file
renanferrari Feb 17, 2020
b8803f8
Rename bottom sheet handle dimension resource
renanferrari Feb 17, 2020
d5f8e13
Simplify the application of styles on the bottom sheet
renanferrari Feb 17, 2020
ea87f27
Fix bottom sheet handle spacing
renanferrari Feb 20, 2020
4a60a07
Rename some bottom sheet dimension resources for consistency
renanferrari Feb 20, 2020
3f59b7a
Extract a style for the main bottom sheet
renanferrari Feb 21, 2020
9a357ea
Merge pull request #11337 from wordpress-mobile/issue/11326-update-my…
develric Feb 21, 2020
3edc97b
Merge branch 'develop' into issue/11343-pr-issue-3
develric Feb 21, 2020
db1c8e8
Update release notes
mchowning Feb 21, 2020
debd401
Update gutenberg submodule ref
mchowning Feb 21, 2020
31ade67
Reverting changes.
develric Feb 21, 2020
7b35d44
Centering list items vertically in bottom sheet and removing margin t…
develric Feb 21, 2020
63c7640
Update gutenberg ref to Gutenberg v1.23.0 release tag
mchowning Feb 21, 2020
371e021
Merge remote-tracking branch 'origin/develop' into gutenberg/integrat…
mchowning Feb 21, 2020
6347458
Changing margin to padding.
develric Feb 21, 2020
2c4618c
Merge pull request #11355 from wordpress-mobile/issue/11343-pr-issue-3
renanferrari Feb 21, 2020
690f9d6
Merge pull request #11331 from wordpress-mobile/gutenberg/integrate_r…
mchowning Feb 21, 2020
0c64406
Merge pull request #11072 from wordpress-mobile/issue-10843/latitude_…
khaykov Feb 22, 2020
256f1e0
Added the missing release note for the Block editor
pinarol Feb 24, 2020
e64f8a0
Merge pull request #11368 from wordpress-mobile/fix/gutenberg-release…
pinarol Feb 24, 2020
e92d69f
Updates translations
oguzkocer Feb 24, 2020
8ef9b90
Bump version number
oguzkocer Feb 24, 2020
16c3cd8
Update metadata translations for 14.2
oguzkocer Feb 24, 2020
e61bb90
Merge pull request #11369 from wordpress-mobile/merge/14.2-into-develop
jkmassel Feb 24, 2020
c250af7
Bump version number
oguzkocer Feb 24, 2020
400c1ea
Update release notes.
oguzkocer Feb 24, 2020
2234f67
Update FluxC version to 1.6.4
oguzkocer Feb 24, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused import
  • Loading branch information
ashiagr committed Feb 17, 2020
commit 4cef88787d0b744118fa625471d86a960268eef5
Original file line number Diff line number Diff line change
@@ -19,7 +19,6 @@
import androidx.annotation.Nullable;
import androidx.fragment.app.Fragment;

import org.jetbrains.annotations.NotNull;
import org.wordpress.android.R;
import org.wordpress.android.WordPress;
import org.wordpress.android.fluxc.model.MediaModel;