Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After gutenberg-mobile v1.22.0 #11225

Merged
merged 6 commits into from
Feb 12, 2020
Merged

After gutenberg-mobile v1.22.0 #11225

merged 6 commits into from
Feb 12, 2020

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Feb 3, 2020

This PR tracks the gutenberg-mobile work that is ready to land in main app's develop but not before the editor v1.22.0 release gets promoted to the new WPAndroid app beta release. In other words, we want these changes to land on develop only after the WPAndroid v14.2 is code-frozen.

If this PR ends up having no changes on top of v1.22.0, it will just be closed without merging anywhere. Unfortunately, GitHub doesn't allow opening a PR with no changes so, this PR currently "looks" like it has a commit, but it doesn't actually have any real changes on top of v1.22.0.

Changes

#10902

To test:

Editor should load up OK in WPAndroid.

PR submission checklist:

  • I have considered adding unit tests where possible. Adding tests is not part of the block editor release process.
  • I have considered adding accessibility improvements for my changes. No new work is scheduled to happen as part of the release process.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hypest hypest added this to the 14.3 milestone Feb 3, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 3, 2020

You can test the changes on this Pull Request by downloading the APK here.

@hypest hypest changed the title Point to gutenberg-mobile v1.22.0 start hash After gutenberg-mobile v1.22.0 Feb 3, 2020
@hypest hypest requested a review from marecar3 February 11, 2020 11:27
@hypest hypest marked this pull request as ready for review February 11, 2020 11:28
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM! 🎉

@hypest hypest self-assigned this Feb 11, 2020
@hypest
Copy link
Contributor Author

hypest commented Feb 11, 2020

Thanks for the review Marko, I will merge when the WPiOS side PR also gets LGTM'd.

@hypest hypest merged commit 17d855f into develop Feb 12, 2020
@hypest hypest deleted the gutenberg/after_1.22.0 branch June 1, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants