Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing reader bottom sheet RTL support. #11301

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Conversation

develric
Copy link
Contributor

@develric develric commented Feb 13, 2020

Fixes #11300

This PR fixes an issue with RTL support as per below images.

Description Wrong 👎 Correct 👍
Following title alignement and SITES list image image
Following title alignement and TAGS list image image

NOTES

  • Some strings for Hebrew language are not set so we get english defaults but the alignements should be correct with this patch.

To test

  • Run the zalpha flavor of the app and check first with English that you get left alignment in the reader bottom sheet like below
image image
  • Change now the language to a RTL language (like Hebrew) and check you get something similar to the Correct 👍 column above.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Member

@renanferrari renanferrari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but I was a bit confused if the ViewPager scrolling direction was correct. After looking into it, it seems that ViewPager doesn't really support RTL layouts anyway and this was only addressed recently with ViewPager2, which we should definitely consider adopting in the future.

Otherwise, LGTM! :shipit:

@develric
Copy link
Contributor Author

Hey @renanferrari ! Thanks for reviewing this 😊!

I was a bit confused if the ViewPager scrolling direction was correct...

Correct, I also needed to check it with behavior in other places across the app to confirm it was aligned.

this was only addressed recently with ViewPager2, which we should definitely consider adopting in the future.

I was not aware that ViewPager2 was introducing RTL support, so good to know and thanks for sharing 🙇‍♂️! I agree we should consider to use it and opened an issue (#11328) to track it 👍.

@develric develric merged commit 6889a34 into develop Feb 17, 2020
@develric develric deleted the issue/ia-reader-rtl-review branch February 17, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reader bottom sheet RTL support.
2 participants