-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release/14.2 to develop #11323
Conversation
Gutenberg hotfix v1.22.1
…notes-14.2 Updates release notes for 14.2 after editorial review
You can test the changes on this Pull Request by downloading the APK here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me.
AFAICT #11298 contains 1.22.1 and develop
contains 1.22 (3dc3f1b) so we should actually favour the one in this release branch if we want the most recent build. I presume the 1.23
version will also contain the changes from 1.22.1
, but I'm not sure what we want to do in the interim.
@hypest – I leave this in your court – I'm ok with everything else besides this so feel free to merge at your discretion!
@hypest It'd be great if you can take a look at this one when you get a chance. Thanks! |
👋 @oguzkocer ! We want the gutenberg ref for 1.22.1 from the release branch in favor of the 1.22.0 ref on |
Due to the gutenberg hotfix there was a conflict merging back to develop. I've accepted the commit hash in
develop
forlibs/gutenberg-mobile
but in this case the hash inrelease/14.2
might be the correct one. @hypest Do you mind verifying that hash for gutenberg will be correct after this merge? If it is not correct, please feel free to directly commit in this branch with the correct hash. Thanks!