Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable login and signup connected tests #11283

Merged

Conversation

oguzkocer
Copy link
Contributor

This PR temporarily disables the login and signup connected tests. I initially intended to only disable the magic link login test, but it looks like even the loginWithSiteAddress is failing.

I am not entirely sure why the loginWithSiteAddress test would care about LoginMagicLinkInterceptActivity, so maybe the previous tests are having an effect or something. In any case, I think it's best to disable all of them for now until we get a chance to look into them.

java.lang.RuntimeException: Could not launch intent Intent { act=android.intent.action.MAIN flg=0x10000000 cmp=org.wordpress.android/.ui.accounts.LoginMagicLinkInterceptActivity } within 45 seconds. Perhaps the main thread has not gone idle within a reasonable amount of time? There could be an animation or something constantly repainting the screen. Or the activity is doing network calls on creation? See the threaddump logs. For your reference the last time the event queue was idle before your activity launch request was 1581436548916 and now the last time the queue went idle was: 1581436579229. If these numbers are the same your activity might be hogging the event queue. 

@oguzkocer oguzkocer added this to the 14.3 milestone Feb 11, 2020
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@jkmassel jkmassel merged commit a00a51a into develop Feb 11, 2020
@jkmassel jkmassel deleted the issue/temporarily-disable-login-and-signup-connected-tests branch February 11, 2020 18:26
@rachelmcr
Copy link
Member

Just to check, did you try disabling only loginWithMagicLink first, to see if the remaining login tests pass once it's disabled? I agree that we should disable anything flaky so we have time to investigate, but I'd like to keep other login tests enabled if possible rather than disable them all.

@oguzkocer
Copy link
Contributor Author

@rachelmcr The tests are only failing some of the time, so I couldn't do a local check for it. I thought we'd disable all of them so we can investigate it later. Having said that, I am happy to re-enable the other tests and see how it works in the CI in the next few days. Just let me know and I'll open the PR :)

Fwiw, I feel like the issue we are having is related to some devices in Firebase. So, I was thinking we'd check each test locally and verify that all requests make sense and we are not getting any warnings about the request mismatches I mentioned about. We can also verify that magic link stuff has no effect on tests that don't use them. If all else looks good, we can look into what the issue is in the Firebase side. That was my thought process when I opened this PR and what I should have documented in the PR description, I just wanted to explore things a bit before making suggestions like this. Hope that makes sense!

@rachelmcr
Copy link
Member

Thanks for the explanation! That makes sense and given the investigation you were considering (and the unknowns around which tests would still be flaky) it seems ok to leave these tests disabled until we have time to do that investigation.

FYI @designsimply — we should be sure to do thorough login testing on WPAndroid betas until these tests are enabled again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants