Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master branch update to support Columbus-4 #422

Merged
merged 84 commits into from
Nov 23, 2020
Merged

Master branch update to support Columbus-4 #422

merged 84 commits into from
Nov 23, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Oct 29, 2020

Summary of changes

Merge v0.4.1 updates to Master branch

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

Yun and others added 30 commits February 12, 2020 16:02
* append new msgs - assoicate oracle prevote & vote with updated whitelist param structure to include illiquid factor on denom property

* append querier for associate oracle prevote, cmd & rest interface to send associate oracle prevote & vote

* append simulation code for associate msgs

* implement import & export for associate prevote

* delete associate prevotes at export for zero height

* change associate to aggregate

* update swagger docs

* store aggregate vote in the keeper to reduce file I/O operation

* add genesis export import feature for aggregate vote

* add codec & cmd tx

* introduce vote targets to avoid directly refering params.Whitelist from oracle slashing, change sdk.DecCoins to types.ExchangeRateTuples on types.AggregateExchangeRateVote

* apply default value for default VotesTarget at genesis import step

* store illiquid factors for safe swap & make vote hash type

* bugfix - delete aggregate votes&prevotes after tally

* ignore vote from the voter who did aggregate vote

* simulation code fix

* skip reward allocation when the reward is zero

* add max exchange rates length limit on aggregate vote msg & return deatils err for aggregate prevote/vote

* for internal map structure, directly stringify validator address to prevent unnecessary bech32fy works

* change to use unique tobin taxes per denom in oracle params & variable name changes

* remove unused yaml definition

* fix lint
* bump sdk version to v0.38.3
* localnet script update
* add clean command & update makefile
* fix docker image name
* prevent bank simulation from returning err on insufficient fee error
* localnet script update
* add clean command & update makefile
* prevent bank simulation from returning err on insufficient fee error
* add burn address
* change burn place from handler to endbloker
* localnet script update
* add clean command & update makefile
* add wasm module
* decrease wasm test weight
* charge tax on the msgs from contract & add treasury querier for tax-rate and tax-cap to enable tax estimation on the contract
* allow reference msg
* add tax charging test
* add client code to auto compute tax on instantiate & execute contract
* not execute deduct fee when computed taxes are zero
* change hex bytes to base64 for wasm module
* remove estimated gas consume test

Co-authored-by: Paul Kim <[email protected]>
* add MsgSwapSend feature

* append MsgSwapSend with tax deduct & wasm interface

* change receiver to toAddress

* convention for parameters to be kebab-cased

Co-authored-by: Paul Kim <[email protected]>
…350)

* add wasm params querier

* add querier test

* fix rest api to load from address

* align wasm query msg to json string

* remove uncessary string wrapper on rest interface

* align rest endpoint expression from singular to plural

* fix swagger example

* add json validation for wasm endpoints
* Bump cosmwasm v0.9.x & append migration feature

* add testcase and client code for migrate & update-owner

* add simulation code for updates

* delete data

* Bump cosmwasm v0.9.2 & go-cosmwasm v0.9.1

* fix swagger example

Co-authored-by: Paul Kim <[email protected]>
* copy from msgauth module from https://github.com/regen-network/cosmos-sdk/tree/regen-network/msg_authorization

* finising msgauth interfaces

* swagger update & client interface update

* remove todo

* convert rest grant limit to coins

* add msgauth simulation

* fix simulation

* fix client description

* remove redundent error tag

* swagger: MsgAuth tag to Authorization

Co-authored-by: Paul Kim <[email protected]>
yun-yeo and others added 12 commits September 22, 2020 17:38
* changelog update
* add columbus-4 genesis migration script

* implement indicators querier for tax rate update

* add public option at starting rest-server & enforce to use tx.height option when public option is on

* fix(treasury): indicator endpoint
feat(treasury): indicator swagger definition

* fix: stringify yes and no map keys (#379)

* change module account name & permission key

* apply core module migration script

* add pretty optiong

* add new modules: msgauth, wasm, mint to script

* update script for wasm params and expected time

* remove wasm gas_multiplier params from genesis migration script

* add changelog

Co-authored-by: Paul Kim <[email protected]>
Co-authored-by: Jesse Chung <[email protected]>
…ed ABCI errors that all map to undefined internal errors. (#414)

This PR maps to the InvalidCoinsError and makes for an easier time debugging AggregateVoteMessages
Merge master to resolve conflict develop<>master
* update wasm event system to restrict from_contract logging to whitelist
* save wasm.toml right after new contract added to whitelist

Co-authored-by: Paul Kim <[email protected]>
@yun-yeo yun-yeo marked this pull request as draft October 29, 2020 03:36
@yun-yeo yun-yeo self-assigned this Oct 29, 2020
@yun-yeo yun-yeo added the daemon daemon updates label Oct 29, 2020
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #422 (df11740) into master (a5262c3) will decrease coverage by 5.35%.
The diff coverage is 67.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   72.87%   67.52%   -5.36%     
==========================================
  Files          73      117      +44     
  Lines        3089     5071    +1982     
==========================================
+ Hits         2251     3424    +1173     
- Misses        731     1433     +702     
- Partials      107      214     +107     
Impacted Files Coverage Δ
x/bank/module.go 0.00% <0.00%> (ø)
x/market/internal/keeper/alias_functions.go 0.00% <0.00%> (ø)
x/market/internal/types/querier.go 0.00% <ø> (ø)
x/market/internal/types/tobin_tax.go 0.00% <0.00%> (-100.00%) ⬇️
x/market/module.go 0.00% <0.00%> (ø)
x/msgauth/internal/types/authorizations.go 0.00% <0.00%> (ø)
x/msgauth/internal/types/generic_authorization.go 0.00% <0.00%> (ø)
x/msgauth/internal/types/keys.go 0.00% <0.00%> (ø)
x/msgauth/internal/types/msgs.go 0.00% <0.00%> (ø)
x/msgauth/internal/types/querier.go 0.00% <0.00%> (ø)
... and 183 more

@hanjukim hanjukim requested review from hanjukim and kjessec November 11, 2020 10:41
hanjukim
hanjukim previously approved these changes Nov 11, 2020
* recover from out-of-gas panic

* fix testing for query panic

* format recovered error depends on the error type
* add softfork condition to staking wasm querier

* formatting

* update error codes bigger than 1

* handle prev error to internal error

* handle prev error to internal error

* fix wrong error type

* add wasm execute msg size limit update

* remove unstable staking begin blocker
@yun-yeo yun-yeo marked this pull request as ready for review November 23, 2020 09:58
@hanjukim hanjukim self-requested a review November 23, 2020 10:01
@hanjukim hanjukim merged commit 748b7a7 into master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
daemon daemon updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants