Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] MsgSwapSend #348

Merged
merged 4 commits into from
Jun 16, 2020
Merged

[Feature] MsgSwapSend #348

merged 4 commits into from
Jun 16, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Jun 15, 2020

Summary of changes

  • New msg type to support swap & send simultaneously
    This RP also includes tax deduct & wasm interface of MsgSwapSend
  • need proposal link

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Jun 15, 2020
@yun-yeo yun-yeo requested a review from hanjukim June 15, 2020 10:46
@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #348 into develop will decrease coverage by 0.02%.
The diff coverage is 59.09%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #348      +/-   ##
===========================================
- Coverage    65.06%   65.04%   -0.03%     
===========================================
  Files          101      101              
  Lines         5110     5152      +42     
===========================================
+ Hits          3325     3351      +26     
- Misses        1581     1597      +16     
  Partials       204      204              
Impacted Files Coverage Δ
x/auth/ante/tax.go 78.78% <0.00%> (-2.47%) ⬇️
x/market/internal/types/msgs.go 53.70% <53.33%> (+1.70%) ⬆️
x/market/handler.go 80.32% <62.96%> (+2.14%) ⬆️
x/market/wasm/interface.go 79.31% <80.00%> (-0.69%) ⬇️
x/market/internal/keeper/test_utils.go 100.00% <100.00%> (ø)
x/market/internal/types/codec.go 100.00% <100.00%> (ø)

x/market/client/cli/tx.go Outdated Show resolved Hide resolved
@yun-yeo yun-yeo requested a review from hanjukim June 16, 2020 07:30
@hanjukim hanjukim merged commit b42a89e into develop Jun 16, 2020
@hanjukim hanjukim deleted the feature/msg-swap-send branch June 16, 2020 08:58
@hanjukim hanjukim added this to the Columbus-4 milestone Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants