Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #412

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Update README.md #412

merged 1 commit into from
Oct 5, 2020

Conversation

ouiliame
Copy link
Contributor

@ouiliame ouiliame commented Oct 3, 2020

Summary of changes

Changed network details and Go version required for building

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #412 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #412   +/-   ##
========================================
  Coverage    67.70%   67.70%           
========================================
  Files          117      117           
  Lines         5038     5038           
========================================
  Hits          3411     3411           
  Misses        1415     1415           
  Partials       212      212           

@yun-yeo yun-yeo merged commit 185e2b7 into develop Oct 5, 2020
@yun-yeo yun-yeo deleted the update-docs branch October 5, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants