[Feature] Prevent state reset of treasury after hard fork #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dokwon
suggested changes
Mar 24, 2020
| @@ -27,7 +27,6 @@ const ( | |||
| BlocksPerWeek = util.BlocksPerWeek | |||
| BlocksPerMonth = util.BlocksPerMonth | |||
| BlocksPerYear = util.BlocksPerYear | |||
| BlocksPerEpoch = util.BlocksPerEpoch | |||
There was a problem hiding this comment.
Removing blocksPerEpoch seems to be a big decision, also one that is quite different from the stated purpose of this pull request. Consider moving to another pull request to avoid future confusion.
| @@ -36,7 +41,7 @@ func (k Keeper) alignCoins(ctx sdk.Context, coins sdk.DecCoins, denom string) (a | |||
|
|
|||
| // UpdateIndicators updates interal indicators | |||
| func (k Keeper) UpdateIndicators(ctx sdk.Context) { | |||
| epoch := core.GetEpoch(ctx) | |||
There was a problem hiding this comment.
Also seems like code changes that are not relevant to treasury data reset
dokwon
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Now we introduce
CumulatedHeightto keep indicator histories which are stored per each epoch even if the block height is reset (at hard fork).When we export genesis for zero height, it will update
CumulatedHeighttoCumulatedHeight+ctx.BlockHeight()for next chain without deleting indicator histories.close #317
Report of required housekeeping
(FOR ADMIN) Before merging