Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CodeSpace undefined error for Mempool errors for ParseExchangeRateTuples #414

Merged

Conversation

zmanian
Copy link
Contributor

@zmanian zmanian commented Oct 6, 2020

This PR maps to the InvalidCoinsError and makes for an easier time debugging AggregateVoteMessages

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

…ed ABCI errors that all map to undefined internal errors.

This PR maps to the InvalidCoinsError and makes for an easier time debugging AggregateVoteMessages
@yun-yeo yun-yeo self-requested a review October 14, 2020 02:04
Copy link
Contributor

@yun-yeo yun-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yun-yeo yun-yeo merged commit 84fd890 into terra-money:develop Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants