Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Bugfix] Make all error code bigger than 1" #429

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

hanjukim
Copy link
Contributor

@hanjukim hanjukim commented Nov 10, 2020

Reverts #417

This change causes result hash mismatch at height 1078 which has an error from MsgSwap message https://finder.terra.money/columbus-4/tx/A9D1B105BEC86B4043162635B68DA4F9BE4FE240D916E4EB8205C1F6DDDB0E89

@hanjukim hanjukim requested a review from yun-yeo November 10, 2020 11:47
@hanjukim hanjukim added the bug Something isn't working label Nov 10, 2020
@hanjukim hanjukim assigned hanjukim and yun-yeo and unassigned hanjukim Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #429 (0e4d615) into develop (4ae926c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #429   +/-   ##
========================================
  Coverage    67.52%   67.52%           
========================================
  Files          117      117           
  Lines         5053     5053           
========================================
  Hits          3412     3412           
  Misses        1427     1427           
  Partials       214      214           

@yun-yeo yun-yeo merged commit f2b6cd6 into develop Nov 10, 2020
@yun-yeo yun-yeo deleted the revert-417-bugfix/fix-error-code branch November 10, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants