Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix tobin tax upate of oracle end blocker #337

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Apr 9, 2020

Summary of changes

Oracle EndBlocker does not update tobin taxes when there are only tobin tax updates without any denom list changes.

  • Fix oracle end blocker to apply tobin tax only changes in whitelist

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo requested a review from hanjukim April 9, 2020 06:24
@yun-yeo yun-yeo self-assigned this Apr 9, 2020
@yun-yeo yun-yeo added bug Something isn't working daemon daemon updates labels Apr 9, 2020
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #337 into develop will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #337      +/-   ##
===========================================
+ Coverage    71.26%   71.36%   +0.09%     
===========================================
  Files           75       75              
  Lines         3644     3646       +2     
===========================================
+ Hits          2597     2602       +5     
+ Misses         901      899       -2     
+ Partials       146      145       -1     

@yun-yeo yun-yeo merged commit 3684f77 into develop Apr 9, 2020
@yun-yeo yun-yeo deleted the bugfix/whitelist-apply branch April 9, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working daemon daemon updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants