-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] WASM integration #335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/wasm
Codecov Report
@@ Coverage Diff @@
## develop #335 +/- ##
===========================================
- Coverage 68.46% 65.06% -3.40%
===========================================
Files 72 101 +29
Lines 3618 5110 +1492
===========================================
+ Hits 2477 3325 +848
- Misses 1004 1581 +577
- Partials 137 204 +67
|
yun-yeo
force-pushed
the
feature/wasm
branch
2 times, most recently
from
May 26, 2020 13:23
cdbab67
to
aa71666
Compare
In current design, wasm module can invoke bank/MsgSend without tax. We need a way to deduct tax from wasm send. |
Deduct tax on instantiate & execute msg seems enough. |
…ate and tax-cap to enable tax estimation on the contract
yun-yeo
added
enhancement
New feature or request
and removed
WIP
work in progress
labels
Jun 2, 2020
hanjukim
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:: THIS MUST BE MERGED AFTER #323
Summary of changes
This PR should be merged after #323
WASM integration
TODO
Report of required housekeeping
(FOR ADMIN) Before merging