Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] WASM integration #335

Merged
merged 52 commits into from
Jun 15, 2020
Merged

[Feature] WASM integration #335

merged 52 commits into from
Jun 15, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Mar 30, 2020

NOTE:: THIS MUST BE MERGED AFTER #323

Summary of changes

This PR should be merged after #323

WASM integration

wait until cosmwasm v0.8 release

TODO

  • Itegrate cosmwasm v0.8.x
  • Combine Config
  • Bank Querier & Handler
  • Staking Querier & Handler
  • Custom Handler & Querier for market module
  • Custom Querier for oracle module

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #335 into develop will decrease coverage by 3.39%.
The diff coverage is 56.24%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #335      +/-   ##
===========================================
- Coverage    68.46%   65.06%   -3.40%     
===========================================
  Files           72      101      +29     
  Lines         3618     5110    +1492     
===========================================
+ Hits          2477     3325     +848     
- Misses        1004     1581     +577     
- Partials       137      204      +67     
Impacted Files Coverage Δ
x/market/internal/types/querier.go 0.00% <ø> (ø)
x/treasury/internal/types/querier.go 0.00% <ø> (ø)
x/wasm/internal/types/connector.go 0.00% <0.00%> (ø)
x/wasm/internal/types/contract.go 0.00% <0.00%> (ø)
x/wasm/internal/types/keys.go 0.00% <0.00%> (ø)
x/wasm/internal/types/msg_binding.go 0.00% <0.00%> (ø)
x/wasm/internal/types/querier.go 0.00% <0.00%> (ø)
x/wasm/internal/types/query_binding.go 0.00% <0.00%> (ø)
x/wasm/module.go 12.06% <12.06%> (ø)
x/wasm/internal/keeper/querier.go 25.00% <25.00%> (ø)
... and 53 more

@yun-yeo yun-yeo added the WIP work in progress label Apr 21, 2020
@yun-yeo yun-yeo force-pushed the feature/wasm branch 2 times, most recently from cdbab67 to aa71666 Compare May 26, 2020 13:23
@yun-yeo
Copy link
Contributor Author

yun-yeo commented May 27, 2020

In current design, wasm module can invoke bank/MsgSend without tax. We need a way to deduct tax from wasm send.

@yun-yeo
Copy link
Contributor Author

yun-yeo commented May 27, 2020

Deduct tax on instantiate & execute msg seems enough.

@yun-yeo yun-yeo changed the title [WIP] WASM integration [Feature] WASM integration Jun 2, 2020
@yun-yeo yun-yeo added enhancement New feature or request and removed WIP work in progress labels Jun 2, 2020
@yun-yeo yun-yeo requested a review from dokwon June 2, 2020 05:18
@hanjukim hanjukim self-requested a review June 15, 2020 00:07
@hanjukim hanjukim merged commit 1b74b35 into develop Jun 15, 2020
@hanjukim hanjukim deleted the feature/wasm branch June 15, 2020 00:12
@hanjukim hanjukim added this to the Columbus-4 milestone Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants