-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rosetta 2.0 Test — Round 1 #869
Comments
for phase 1 testing: I used win10 chrome and Nancy used MacOS 13 Safari 16 |
Hi team! I really like the view and the new features! The first time I access, it takes some time to load all the information about the percentage of the strings translated in that locale, but the second time, it was faster, looks like is saving some data. I like the links to go back to the Sims list and the Select Locale. I said @liammulh that in the beginning I thought that this button will copy the English string to the clipboard for me to paste it in Google Translate for example. But no, this button put the English string to the Translation. A tooltip will be enough to solve this confusion, but I am still thinking that a functionality that allow to copy the English strings to the clipboard is also super useful to think in a future improvement. I also think that the Save, Publish and Test buttons need to be always visible while we are translating. It is not a good user experience to have to scroll up or down to access this buttons. Also, a button that said, “Go to the top” always visible can be good! It is not a good experience to finish translating a sim, you want to move to another sim or go back to the list of sims/locales, and need to scroll all the way up. It is possible to have the information in the picture always visible while we are translating the strings? I always give a fast scroll up-down to be sure that I translate all strings, but having this information, I think, is more efficient. I use control+f to look for the sim I want to translate, but probably a search option cool be a good idea, specially for tablets, but I know that this is more for computer users. When I clicked the buttons in the picture I expected to see the list to reorder for the sim with less or more strings, or less or more common strings, but no, the list reorder alphabetic. It is the behavior expected for the same button in the “Sim title”, but in the other column titles it was strange. Looks like these buttons are only useful in the “translated sims” table, where it reorders the sims according to the %. Is normal that when I test a sim, the tab loos like is always loading? I have to accept that I didn't see the “Translation saved” message the first time. It has the same color that the page and appears at the top of the page. I finish translating something in the bottom of the page, click Save, and didn't realize why I couldn't scroll the page until I saw the small window. Probably move it to the center of the page with a more colorful ackgorund, or just close to the Save button. These are all my comments. Amazing job team! |
Great work @liammulh. It's so nice to see the progress. Phase 1:
Others Out of scope(phase 1);
|
I think adding a search feature would increase the complexity of the client-side code significantly and it would really only be a feature for people who translate on tablets, so I'm very reluctant to add this. Also, it's possible to search web pages on mobile now, at least in Safari on iOS.
The sim title button sorts according to sim title, the sim-specific column sorts according to sim-specific percentage, and the common button sorts according to common percentage. @DianaTavares, what is confusing about the buttons? It's true the sim-specific button in the untranslated table doesn't really do anything since all of the sims have 0 percent. We could disable that button or make it so that it doesn't do anything. @DianaTavares, what do you think about this?
No, I don't think that's normal. I think that needs an issue.
We don't have control over where the pop-up happens. It's controlled by the web browser. In a future release, we could create and position our own modal, I think. |
It is ok without a search option. My confusion about the sort buttons is that in the no translated sim they don't do anything because all the percentages are 0%. I like the idea of disable them (or delete them from this table). Because buttons that don't do anything make think that something is wrong. I understand the pop-up comment. It is ok if we can't control its position. Thanks for answer all my comments!! |
Noted. I made phetsims/rosetta#340 for this.
Saving the translation will not affect whether it is in the "not yet translated" or "translated" list. It also won't affect the statistics for the number of strings translated. The "not yet translated" or "translated" lists can only change if you click the publish button. Similarly, the string statistics can only change if you click the publish button.
This is a feature we plan to add, but not for this version of Rosetta, unfortunately. This issue is tracked in phetsims/rosetta#325. Actually, now that I think about it, we could add an alert just for clicking the "Back to {Locale} {locale-code}" link. It wouldn't handle the case if someone clicked a different link or if they tried to close the tab. |
Thank you @DianaTavares and @solaolateju for all of your feedback! I appreciate it! :) |
I'm going to use this comment to track the issues that have come out of testing and what I plan on doing about them.
|
Add prompt to save when user clicks the "Back to {locale} {locale-code} Sim List" button. See #341. Part of phetsims/qa#869.
All issues have been addressed. Closing. |
Add prompt to save when user clicks the "Back to {locale} {locale-code} Sim List" button. See #341. Part of phetsims/qa#869.
Part of #332. Also part of phetsims/qa#869.
Part of #332. Also part of phetsims/qa#869.
Part of #332. Also part of phetsims/qa#869.
See #341. Specifically, see #341 (comment). This came out of phetsims/qa#869.
Part of #344. Came out of phetsims/qa#869.
For #344. Came out of phetsims/qa#869.
If there are no string keys for a given key type (sim-specific, shared, or common), we set the number of translated strings in the form to 0. For #345. Came out of phetsims/qa#869.
For #347. Came out of phetsims/qa#869.
For #347. Came out of phetsims/qa#869.
This commit just adds the `<td>` cells with shared stats. We still need to wire things up to handle shared stats. For #347. Came out of phetsims/qa#869.
Show stats in the report table. Still need to wire things up for sorting. For #347. Came out of phetsims/qa#869.
For #347. Came out of phetsims/qa#869.
The commit before this introduced an issue where the shared stats weren't showing for sims in the "unpublished" table. This commit fixes that. For #347. Came out of phetsims/qa#869.
Should resolve #332 and #340. Came out of phetsims/qa#869.
For #348. Came out of phetsims/qa#869.
For #348. Came out of phetsims/qa#869.
For #348. Came out of phetsims/qa#869.
For #348. Came out of phetsims/qa#869.
@KatieWoe, @kathy-phet, @oliver-phet, and @jbphet, Rosetta 2.0 is feature-complete and ready for testing.
There are two main objectives to this test:
This might sound simple, but there's a lot behind both of these objectives. We will test in phases.
Think of the checkboxes as "bare minimum" testing. It be good to do a bit of "dev" testing where you're just trying to break things. It would also be good to do a bit of "RC" testing where you verify things are behaving the same on different browsers. We don't really care about mobile devices.
Also, QA has a set of "testing" logins to the PhET website. You might want to use those for testing as if you aren't a team member, but you are a trusted translator.
As always, feel free to ask questions. Since @jbphet is busy trying to get Greenhouse out the door, please direct questions to me.
We might have another phase where we actually have some builds done when you hit the publish button, but this will require coordination with Jonathon Olson and Matt Pennington, and we'll need to be careful about the configuration and which sims we publish.
The test can be accessed by going to https://ox-dev.colorado.edu/translate. @mattpen is testing working on the sign-in to the website, so it's possible you'll have trouble signing in at some point.
At some point, ideally during phase 1, it would be great if we could get @solaolateju and/or @DianaTavares to do a bit of testing. I will ping them on Slack on Monday.
Assigning @kathy-phet for prioritization.
As of this writing (11 PM Friday night), I'm not able to sign in to Ox-Dev, and Rosetta seemingly can't hit the website user data route on Ox-Dev. Right now, Rosetta is configured to use https://phet-direct-dev.colorado.edu/user/check-login as the website user data route. Hopefully @mattpen can take a look on Monday morning.
@KatieWoe, I wasn't sure what labels to add, so I didn't add any, but if you think it needs certain labels, please add them.
Phase 1: Test New Features
Be aware that the publish button is not meant to be working during this phase.
given locale load properly
Babel. If they really want to be thorough, they can count the
total number of strings in the published sim. If they want to do
this, they should ask me for a copy of the strings file for the
published sim.
don't match
there are form errors
Phase 2: Test Old Features
Be aware that during this phase, the publish button should work, and it will commit strings to the test branch of Babel.
Babel
badge next to it
SIM_METADATA_VALID_DURATION
or tenminutes, whichever is the greater
wait about ten minutes, they see the strings from Babel, not strings
they saved
publish it, and then wait ten minutes. When you come back, you
should see the strings that are in Babel in the form rather than your
saved strings. (The saved translation should be deleted from the
database when you publish.)
Phase 3: Test Down for Maintenance / Sign-In / Permissions
Phase 3 Part A
down for maintenance
Phase 3 Part B
member can't access the translation utility
access the translation utility
access the translation utility
The text was updated successfully, but these errors were encountered: