Curly brace validation not working for shared string keys

[liammulh]

While testing a new tooltip for translators about how to correctly translate curly brace patterns, I noticed that our validation wasn't running correctly for a string key with markup and double curly braces in ab/diffusion:

How it's supposed to look:

Some questions:

• Is this happening in Rosetta 1.0?

  • No.

• Is this happening for all string keys with both markup and curly braces?

Wow, interestingly, no. This isn't an issue in ab/fourier-making-waves:

• Is this happening for string keys with markup and single curly braces?
  • Seemingly, no.
  • See ab/acid-base-solutions pattern.0value.1power.
  • See ab/forces-and-motion-basics pattern.0name.1valueUnitsAcceleration.

[liammulh]

I think I know what the issue is. The makeValidationSchema.js module was written before we added support for shared strings. I bet tAvg and tAvgK are shared strings, and those strings aren't getting validation schemas. Going to try to validate my hypothesis.

[liammulh]

tAvg and tAvgK are indeed shared strings. Going to try to fix now...

[liammulh]

Should be fixed in 8f30184. Marking as ready for review for next round of testing.

[Nancy-Salpepi]

looks good in round 2.