feat: show shared stats in report table

Show stats in the report table. Still need to wire things up for sorting. For #347. Came out of phetsims/qa#869.
phetsims · Feb 8, 2023 · 874aee3 · 874aee3
1 parent ea38012
commit 874aee3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/client/components/TranslationReportTable.jsx b/src/client/components/TranslationReportTable.jsx
@@ -90,6 +90,13 @@ const TranslationReportTable = ( { locale, localeName, wantsUntranslated } ) =>
               : <></>
             }
           </th>
+          <th>Shared Strings
+            {
+              reportPopulated && reportRows.length > 1
+              ? <SortButton onClick={() => handleSortButtonClick( 'need to put sort key here' )}/>
+              : <></>
+            }
+          </th>
           <th>Common Strings
             {
               reportPopulated && reportRows.length > 1

diff --git a/src/client/jsx/getTranslationReportRows.jsx b/src/client/jsx/getTranslationReportRows.jsx
@@ -79,7 +79,7 @@ const getTranslationReportRows = (
     // Create the row JSX.
     const simSpecificPercent = Math.floor( ( reportObject.numSimSpecificTranslatedStrings / reportObject.numSimSpecificStrings ) * 100 );
     let sharedPercent = 0;
-    const hasSharedStrings = reportObject.numSharedStrings && reportObject.numSharedTranslatedStrings;
+    const hasSharedStrings = reportObject.numSharedStrings !== undefined && reportObject.numSharedTranslatedStrings !== undefined;
     let sharedJsx = <td>N/A</td>;
     const commonPercent = Math.floor( ( reportObject.numCommonTranslatedStrings / reportObject.numCommonStrings ) * 100 );
     if ( hasSharedStrings ) {