Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot immediately test or publish a saved translation #346

Open
KatieWoe opened this issue Dec 22, 2022 · 5 comments
Open

Cannot immediately test or publish a saved translation #346

KatieWoe opened this issue Dec 22, 2022 · 5 comments

Comments

@KatieWoe
Copy link

For phetsims/qa#869. Seen in phase 2 on Win 11 Chrome.
If you save a translation and come back to it, you can not immediately publish or test the translation as it was saved. You must make a change in order for those buttons to not be greyed out. This could be a problem if someone finishes a translation, saves it, and comes back later to check it and publish it. They won't be able to publish it without making a change.
Steps:

  1. Choose a language and sim
  2. Make a change and save it
  3. Leave come back some time later
  4. Choose the same language and sim again
  5. The saved translation should be there, but the save, publish, and test buttons are grey
@Nancy-Salpepi
Copy link

I also noticed this and found it a poor user experience that I had to make a "fake" change in order to enable the buttons.

@liammulh
Copy link
Member

I think the solution to this would be to have a boolean in the translation form data that indicates whether the translation form data was retrieved from the short-term storage database. Then we could set the buttons to enabled according to that boolean.

@liammulh
Copy link
Member

liammulh commented Mar 5, 2023

Not high priority for me right now. I will reassign when I get to it.

@liammulh liammulh removed their assignment Mar 5, 2023
@KatieWoe
Copy link
Author

Noting that I ran into this and it tripped me up during phetsims/qa#931

@jbphet
Copy link
Contributor

jbphet commented Jun 14, 2023

Discussed in 6/14/2023 review meeting and decided that this is not currently a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants