-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we add a "Total" column to the translation report? #348
Comments
This sounds like more of a 2.1 feature. I'd recommend focusing on #332 (comment) |
There is another issue that is also about adding a column, and we should consider that one when evaluating this one, since we don't want to make the report look too cluttered. See #347. |
Discussed with @liammulh today. We decided it would be best to move to a single column "Strings Translated" that is a composite of sim-specific, shared, and common strings. Updated design: |
For #348. Came out of phetsims/qa#869.
For #348. Came out of phetsims/qa#869.
For #348. Came out of phetsims/qa#869.
For #348. Came out of phetsims/qa#869.
I think as of 48bb47a, the total column is working as envisioned in this issue. I will mark this as ready to review. |
Things looks good in round 2--there is now only one column: Translated Strings. The associated sort button is working as it should. Next to each percentage there is now an info button which separates out the strings by type. Closing. |
For #348. Came out of phetsims/qa#869.
For #348. Came out of phetsims/qa#869.
For #348. Came out of phetsims/qa#869.
For #348. Came out of phetsims/qa#869.
As of this writing, the columns for the translation report look like this:
This makes it a little hard for users to answer questions like "What sims need the least work to finish up?" or "Which sims need the most work?". Should we consider adding a "Total" column to make this easier? My guess is that they would use that column for sorting more than the others.
The text was updated successfully, but these errors were encountered: