Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Pending Update" doesn't appear #345

Closed
Tracked by #878
, #888 ,  #362
...
Nancy-Salpepi opened this issue Dec 22, 2022 · 4 comments
Closed
Tracked by #878
, #888 ,  #362
...

"Pending Update" doesn't appear #345

Nancy-Salpepi opened this issue Dec 22, 2022 · 4 comments
Assignees
@liammulh
Labels
status:ready-for-review type:bug

Comments

@Nancy-Salpepi
Copy link

For phetsims/qa#869, on macOS 13.0.1 and safari 16.1

In phase II testing, the "Pending Update" badge doesn't appear next to the published sim.
@liammulh liammulh mentioned this issue Dec 22, 2022
Closed
29 tasks
@liammulh
Copy link
Member

I'm seeing this when I try to hit the publish button:

Warning: An unhandled error was caught from submitForm() TypeError: a[c] is undefined
    uI submitTranslation.js:38
    onSubmit TranslationForm.jsx:113
    rg formik.esm.js:942
    Me formik.esm.js:1256
    Ze formik.esm.js:858
    promise callback*iT/Ze< formik.esm.js:834
    Me formik.esm.js:1256
    tg formik.esm.js:922
    Me formik.esm.js:1256

I think a[c] is if ( translatedStringsData[ keyType ].translated !== undefined ) { (line 38 of submitTranslation.js).

@liammulh
Copy link
Member

Chrome seems to have a better error message:

Warning: An unhandled error was caught from submitForm() TypeError: Cannot read properties of undefined (reading 'translated')
    at uI (submitTranslation.js:38:43)
    at async onSubmit (TranslationForm.jsx:113:15)
(anonymous) @ formik.esm.js:923
Promise.catch (async)
(anonymous) @ formik.esm.js:922
(anonymous) @ formik.esm.js:1256
kg @ react-dom.production.min.js:52
Dg @ react-dom.production.min.js:52
Ig @ react-dom.production.min.js:53
mf @ react-dom.production.min.js:100
Jh @ react-dom.production.min.js:101
(anonymous) @ react-dom.production.min.js:113
Fh @ react-dom.production.min.js:292
Rg @ react-dom.production.min.js:50
tm @ react-dom.production.min.js:105
bu @ react-dom.production.min.js:75
Ou @ react-dom.production.min.js:74
e.unstable_runWithPriority @ scheduler.production.min.js:18
vr @ react-dom.production.min.js:122
bh @ react-dom.production.min.js:292
Qg @ react-dom.production.min.js:73

liammulh added a commit that referenced this issue Dec 24, 2022
@liammulh
fix: if no keys, set number of translated to 0
ee67172 
If there are no string keys for a given key type (sim-specific, shared,
or common), we set the number of translated strings in the form to 0.

For #345.

Came out of phetsims/qa#869.
@liammulh
Copy link
Member

I believe ee67172 fixes the bug I described above. Hopefully this will allow the translation to actually be submitted, so that the pending update badge can be seen. Marking this as ready for review.

@liammulh liammulh mentioned this issue Jan 6, 2023
Closed
42 tasks
This was referenced Jan 26, 2023
Closed
Closed
liammulh added a commit that referenced this issue Feb 8, 2023
@liammulh
fix: if no keys, set number of translated to 0
7b5774f 
If there are no string keys for a given key type (sim-specific, shared,
or common), we set the number of translated strings in the form to 0.

For #345.

Came out of phetsims/qa#869.
@Nancy-Salpepi
Copy link
Author

In round 3, I needed to clear my history and log in again for "pending update" to be shown with mac + safari.
@stemilymill did not have to clear her cache to see the update with Win10 + chrome.

I think it is ok to close. Please reopen if you disagree @liammulh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liammulh liammulh

Labels
status:ready-for-review type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liammulh @Nancy-Salpepi